Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1655241
| From | Soheil Hassas Yeganeh <soheil@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping |
| Date | 2017-06-01 17:20 +0200 |
| Message-ID | <tNA3g-4do-15@gated-at.bofh.it> (permalink) |
| References | <tNyXv-3yr-5@gated-at.bofh.it> <tNz7c-3D6-41@gated-at.bofh.it> <tNzqy-3Jw-5@gated-at.bofh.it> <tNzAe-3MT-23@gated-at.bofh.it> <tNA3f-4do-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jun 1, 2017 at 11:10 AM, Cyril Hrubis <chrubis@suse.cz> wrote:
>> Thank you for the confirmation. Could you please try the following
>> patch to see if it fixes your issue?
>
> Does not seem to help, I still got the same bussy loop.
Thank you for trying the patch. Unfortunately, I can't reproduce on my
machines here.Would you humor me with another one? Thank you!
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 5a726161f4e4..49207298fcea 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -3742,7 +3742,8 @@ EXPORT_SYMBOL(sock_queue_err_skb);
static bool is_icmp_err_skb(const struct sk_buff *skb)
{
return skb && (SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_ICMP ||
- SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_ICMP6);
+ SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_ICMP6 ||
+ SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_LOCAL);
}
struct sk_buff *sock_dequeue_err_skb(struct sock *sk)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Cyril Hrubis <chrubis@suse.cz> - 2017-06-01 16:10 +0200
Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Soheil Hassas Yeganeh <soheil@google.com> - 2017-06-01 16:20 +0200
Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Cyril Hrubis <chrubis@suse.cz> - 2017-06-01 16:40 +0200
Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Soheil Hassas Yeganeh <soheil@google.com> - 2017-06-01 16:50 +0200
Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Cyril Hrubis <chrubis@suse.cz> - 2017-06-01 17:20 +0200
Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Soheil Hassas Yeganeh <soheil@google.com> - 2017-06-01 17:20 +0200
Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Cyril Hrubis <chrubis@suse.cz> - 2017-06-01 17:40 +0200
Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Soheil Hassas Yeganeh <soheil@google.com> - 2017-06-01 18:50 +0200
Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Cyril Hrubis <chrubis@suse.cz> - 2017-06-01 22:10 +0200
csiph-web