Re: [PATCH] PHY: Exynos: fix I2C dependency for Exynos5250 SATA

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PHY: Exynos: fix I2C dependency for Exynos5250 SATA
Date	2017-05-31 12:20 +0200
Message-ID	<tN8To-3pQ-3@gated-at.bofh.it> (permalink)
References	<tMLDr-5ux-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 30, 2017 at 11:28 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> Device drivers should not 'select' other subsystems, but rather use
> 'depends on', to avoid Kconfig dependency loops. This one even
> selects a particular I2C host driver for no reason, so we can
> remove the select of that particular driver, and turn the I2C
> 'select' into 'depends on'.
>
> Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/phy/samsung/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig
> index b7e0645a7bd9..76475b01780d 100644
> --- a/drivers/phy/samsung/Kconfig
> +++ b/drivers/phy/samsung/Kconfig
> @@ -83,10 +83,9 @@ config PHY_EXYNOS5250_SATA
>         tristate "Exynos5250 Sata SerDes/PHY driver"
>         depends on SOC_EXYNOS5250
>         depends on HAS_IOMEM
> +       depends on I2C
>         depends on OF
>         select GENERIC_PHY
> -       select I2C
> -       select I2C_S3C2410
>         select MFD_SYSCON
>         help
>           Enable this to support SATA SerDes/Phy found on Samsung's

I think this effectively might disable the I2C_S3C2410 on
exynos_defconfig. Previously, the defconfig chosen PHY_EXYNOS5250_SATA
which selected the I2C_S3C2410. Now the I2C_S3C2410 will remain
forgotten.

BTW, It might be also useful to do similar for EXTCON and PHY_ROCKCHIP_TYPEC.

Best regards,
Krzysztof

Thread

[PATCH] PHY: Exynos: fix I2C dependency for Exynos5250 SATA Arnd Bergmann <arnd@arndb.de> - 2017-05-30 11:30 +0200
  Re: [PATCH] PHY: Exynos: fix I2C dependency for Exynos5250 SATA Krzysztof Kozlowski <krzk@kernel.org> - 2017-05-31 12:20 +0200
    Re: [PATCH] PHY: Exynos: fix I2C dependency for Exynos5250 SATA Arnd Bergmann <arnd@arndb.de> - 2017-05-31 12:30 +0200

csiph-web