Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

From	Archit Taneja <architt@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.
Date	2017-05-31 10:40 +0200
Message-ID	<tN7kD-2mN-39@gated-at.bofh.it> (permalink)
References	(1 earlier) <tG1ai-1ut-19@gated-at.bofh.it> <tMSEW-1o1-29@gated-at.bofh.it> <tN5iO-1a0-9@gated-at.bofh.it> <tN6Rz-2bM-5@gated-at.bofh.it> <tN6RA-2bM-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 05/31/2017 01:37 PM, Boris Brezillon wrote:
> Hi Archit,
>
> Le Wed, 31 May 2017 13:31:16 +0530,
> Archit Taneja <architt@codeaurora.org> a écrit :
>
>> Hi Boris,
>>
>> On 05/31/2017 11:56 AM, Boris Brezillon wrote:
>>> Hi Philippe,
>>>
>>> Le Tue, 30 May 2017 16:55:42 +0000,
>>> Philippe CORNU <philippe.cornu@st.com> a écrit :
>>>
>>>> Hi Eric,
>>>>
>>>> I took your patch for the panel-bridge and it works perfectly in both
>>>> DPI mode (panel RGB //) and DSI mode (bridge dw mipi dsi), bravo :-)
>>>
>>> I still don't understand how it can work without a call to
>>> drm_bridge_attach() (which is used to link the RGB encoder to the DPI
>>> connector). I'm probably missing something obvious. Maybe someone can
>>> point it out :-).
>>
>> I think the expectation is that there will be a follow-up patch that
>> would add bridge support. Philippe had posted a patch for adding bridges
>> to ltdc before:
>>
>> https://patchwork.kernel.org/patch/9724835/
>>
>> He can now redo his patch over Eric's panel-bridge patch-set.
>
> But by doing that you're breaking bisectability, or is it working when
> applying only Eric's patchset?
>
> If applying this patch breaks the driver, why not applying it after
> bridge support has been added to this driver?

Yeah, it would break the driver. Philippe can create a patch that adds
bridge support using the panel-bridge glue layer using Eric's patch as a
reference. In the end, there should only be a single patch.

Thanks,
Archit

>
> Regards,
>
> Boris
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Thread

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Philippe CORNU <philippe.cornu@st.com> - 2017-05-30 19:00 +0200
  Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-31 08:30 +0200
    Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Archit Taneja <architt@codeaurora.org> - 2017-05-31 10:10 +0200
      Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-31 10:10 +0200
        Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Archit Taneja <architt@codeaurora.org> - 2017-05-31 10:40 +0200
          Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Philippe CORNU <philippe.cornu@st.com> - 2017-06-01 12:00 +0200

csiph-web