Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1654017
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jakub Kicinski <kubakici@wp.pl> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next] nfp: add MAY_USE_DEVLINK dependency |
| Date | Wed, 31 May 2017 11:00:01 +0200 |
| Message-ID | <tN7DX-2u7-1@gated-at.bofh.it> (permalink) |
| References | <tN7aX-2iQ-41@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1496221047; bh=dcAE8ee9hqrxtlShLf9opIzC1Vdq/2nxuSkkPpV5kHU=; h=From:To:Cc:Subject; b=gaV9VA/PQvTWmppdyFVPWFw9vmiYlBilOdVpD1BnIzbDJLTQUvI0/ShRKGPXCfFeo BoBNxe4Ia7X1lUJ9iz7IPgYeuT1DnQWo4NuX4DOxZcfBkhpl02aXwYo6xo3i+tVO9v v4sAn68MO+BfmqnU6/bkUj/v1fFitQiZWs5bx/pM= |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=US-ASCII |
| Content-Transfer-Encoding | 7bit |
| X-Wp-Mailid | 3d038e2fc4eecc8c3336f26665cc31b8 |
| X-Wp-Av | skaner antywirusowy Poczty Wirtualnej Polski |
| X-Wp-Spam | NO 000000A [cRM0] |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 15 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Simon Horman <simon.horman@netronome.com>, "David S. Miller" <davem@davemloft.net>, oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Wed, 31 May 2017 01:57:21 -0700 |
| X-Original-Message-ID | <20170531015721.7a6d230e@cakuba.lan> |
| X-Original-References | <20170531081700.1948289-1-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1654017 |
Show key headers only | View raw
On Wed, 31 May 2017 10:16:50 +0200, Arnd Bergmann wrote:
> When devlink is configured as a loadable module, a built-in nfp driver
> causes a link error:
>
> drivers/net/built-in.o: In function `nfp_devlink_port_register':
> (.text+0xb8b05): undefined reference to `devlink_port_type_eth_set'
> drivers/net/built-in.o: In function `nfp_devlink_port_register':
> (.text+0xb8b16): undefined reference to `devlink_port_split_set'
>
> This adds a special Kconfig dependency on CONFIG_MAY_USE_DEVLINK
> to avoid that combination and force nfp to be a module when NET_DEVLINK=m.
Thanks, this should be fixed in net-next already by commit
d935bc84c940 ("nfp: add MAY_USE_DEVLINK dependency"). Same
subject/commit title as yours :)
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH net-next] nfp: add MAY_USE_DEVLINK dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-31 10:30 +0200 Re: [PATCH net-next] nfp: add MAY_USE_DEVLINK dependency Jakub Kicinski <kubakici@wp.pl> - 2017-05-31 11:00 +0200
csiph-web