Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653971

[PATCH 08/28] ext4: fix ref counting for ea_inode

Show all headers | View raw

The ref count on ea_inode is incremented by
ext4_xattr_inode_orphan_add() which is supposed to be decremented by
ext4_xattr_inode_array_free(). The decrement is conditioned on whether
the ea_inode is currently on the orphan list. However, the orphan list
addition only happens when journaling is enabled. In non-journaled case,r
we fail to release the ref count causing an error message like below.

"VFS: Busy inodes after unmount of sdb. Self-destruct in 5 seconds.
Have a nice day..."

Signed-off-by: Tahsin Erdogan <tahsin@google.com>
---
 fs/ext4/xattr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 32ad2f2870e9..13daf634244b 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -2098,8 +2098,7 @@ ext4_xattr_inode_array_free(struct inode *inode,
 		if (err)
 			continue;
 		/* for inode's i_count get from ext4_xattr_delete_inode */
-		if (!list_empty(&EXT4_I(ea_inode)->i_orphan))
-			iput(ea_inode);
+		iput(ea_inode);
 		clear_nlink(ea_inode);
 		iput(ea_inode);
 	}
-- 
2.13.0.219.gdb65acc882-goog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/28] ext4: xattr-in-inode support Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:20 +0200
  [PATCH 05/28] ext4: attach jinode after creation of xattr inode Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:20 +0200
  [PATCH 08/28] ext4: fix ref counting for ea_inode Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:20 +0200
  [PATCH 25/28] ext4: add ext4_is_quota_file() Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 15/28] ext4: fix ext4_xattr_move_to_block() Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 24/28] ext4: rename mb block cache functions Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 21/28] ext4: modify ext4_xattr_ino_array to hold struct inode * Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 23/28] mbcache: make mbcache more generic Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 13/28] ext4: ext4_xattr_value_same() should return false for external data Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 11/28] ext4: clean up ext4_xattr_inode_get() Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 12/28] ext4: add missing le32_to_cpu(e_value_inum) conversions Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 20/28] ext4: improve journal credit handling in set xattr paths Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 19/28] ext4: ext4_xattr_delete_inode() should return accurate errors Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 14/28] ext4: fix ext4_xattr_make_inode_space() value size calculation Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 16/28] ext4: fix ext4_xattr_cmp() Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:30 +0200
  [PATCH 10/28] ext4: change ext4_xattr_inode_iget() signature Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:40 +0200
  [PATCH 04/28] ext4: do not set posix acls on xattr inodes Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:40 +0200
  [PATCH 07/28] ext4: call journal revoke when freeing ea_inode blocks Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:40 +0200
    Re: [PATCH 07/28] ext4: call journal revoke when freeing ea_inode  blocks "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-05-31 18:20 +0200
      Re: [PATCH 07/28] ext4: call journal revoke when freeing ea_inode blocks Tahsin Erdogan <tahsin@google.com> - 2017-05-31 23:10 +0200
      Re: [PATCH 07/28] ext4: call journal revoke when freeing ea_inode  blocks Andreas Dilger <adilger@dilger.ca> - 2017-06-06 00:10 +0200
  [PATCH 09/28] ext4: extended attribute value size limit is enforced by vfs Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:40 +0200
    Re: [PATCH 09/28] ext4: extended attribute value size limit is  enforced by vfs "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-05-31 18:10 +0200
      Re: [PATCH 09/28] ext4: extended attribute value size limit is  enforced by vfs Tahsin Erdogan <tahsin@google.com> - 2017-05-31 18:20 +0200
  [PATCH 06/28] ext4: ea_inode owner should be the same as the inode owner Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:40 +0200
  Re: [PATCH 01/28] ext4: xattr-in-inode support "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-05-31 18:50 +0200
    Re: [PATCH 01/28] ext4: xattr-in-inode support Tahsin Erdogan <tahsin@google.com> - 2017-05-31 22:10 +0200
      [PATCH v2 01/28] ext4: xattr-in-inode support Tahsin Erdogan <tahsin@google.com> - 2017-06-01 18:00 +0200

csiph-web