Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653963
| From | Tahsin Erdogan <tahsin@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 17/28] ext4: fix credits calculation for xattr inode |
| Date | 2017-05-31 10:20 +0200 |
| Message-ID | <tN71g-2f2-29@gated-at.bofh.it> (permalink) |
| References | <tN71f-2f2-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
When there is no space for a value in xattr block, it may be stored
in an xattr inode even if the value length is less than
EXT4_XATTR_MIN_LARGE_EA_SIZE(). So the current assumption in credits
calculation is wrong.
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
---
fs/ext4/xattr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 739f73a5a345..dcf7ec98f138 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -1590,8 +1590,7 @@ ext4_xattr_set(struct inode *inode, int name_index, const char *name,
if (error)
return error;
- if ((value_len >= EXT4_XATTR_MIN_LARGE_EA_SIZE(sb->s_blocksize)) &&
- ext4_has_feature_ea_inode(sb)) {
+ if (ext4_has_feature_ea_inode(sb)) {
int nrblocks = (value_len + sb->s_blocksize - 1) >>
sb->s_blocksize_bits;
--
2.13.0.219.gdb65acc882-goog
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 17/28] ext4: fix credits calculation for xattr inode Tahsin Erdogan <tahsin@google.com> - 2017-05-31 10:20 +0200
csiph-web