[PATCH] bcache: Fix a sleep-in-atomic bug

From	Jia-Ju Bai <baijiaju1990@163.com>
Newsgroups	linux.kernel
Subject	[PATCH] bcache: Fix a sleep-in-atomic bug
Date	2017-05-31 09:30 +0200
Message-ID	<tN6eS-1Kf-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The driver may sleep under a spin lock, and the function call path is:
journal_wait_for_write (acquire the lock by spin_lock)
  closure_sync
    schedule --> may sleep

To fix it, the lock is released before "closure_sync", and the lock is 
acquired again after this function.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
 drivers/md/bcache/journal.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c
index 1198e53..ad47c36 100644
--- a/drivers/md/bcache/journal.c
+++ b/drivers/md/bcache/journal.c
@@ -724,6 +724,7 @@ static struct journal_write *journal_wait_for_write(struct cache_set *c,
 			btree_flush_write(c);
 		}
 
+		spin_unlock(&c->journal.lock);
 		closure_sync(&cl);
 		spin_lock(&c->journal.lock);
 		wait = true;
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] bcache: Fix a sleep-in-atomic bug Jia-Ju Bai <baijiaju1990@163.com> - 2017-05-31 09:30 +0200
  Re: [PATCH] bcache: Fix a sleep-in-atomic bug Kent Overstreet <kent.overstreet@gmail.com> - 2017-05-31 10:00 +0200
  Re: [PATCH] bcache: Fix a sleep-in-atomic bug Jia-Ju Bai <baijiaju1990@163.com> - 2017-05-31 10:40 +0200

csiph-web