Re: [RFC][PATCH 00/23] VFS: Introduce superblock configuration context [ver #4]

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Miklos Szeredi <mszeredi@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 00/23] VFS: Introduce superblock configuration context [ver #4]
Date	Wed, 31 May 2017 10:00:01 +0200
Message-ID	<tN6HT-1Tw-7@gated-at.bofh.it> (permalink)
References	<tJXUu-7yP-3@gated-at.bofh.it> <tMRpv-GU-9@gated-at.bofh.it> <tMRpv-GU-7@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZsM3pyH+l9LFMMVj+XmdZtR2GNNMN4sTyIyDJU2QsiU=; b=Un6J6Fm/UZkndNDFG326uWLR3Yu6VRM9TduEQfLksU8Bxi3seVJ+RdLmJPYpPqFGqj UcHH1pz+GfMwu1cMDw3D74cibAAhsG0CaAV3IFrFNPFjnm3DjGkL9jDH7U3aDSldtq/r CZZ1Ttg/V+7TDDJ3SIKJ4mJj2jD4xBrTmKiBmnVGvlN/Cma1kIPQA4tOixaCwLwbSTMX /5Or/BlhYsFCgeBo8uv70a6nfRhIXSxIfCAw66DCSxOHK+rj7dthyxMS8jqiNW8zFpDc 7N8dOg+BVMrFWHjmDDvgPjnx8i9MjK2jYVj4LSNxv+T5EFWH8kQkGwMqdjcY4cgbqxen k2wg==
X-Gm-Message-State	AODbwcAkd42OnrVUl+4GvloY2H3xdlFYYNeWhESiRpeQ73O2WuBvEvEw a1PpxvKrgdgTca05Z7JNbhtcEm+R3LRb
X-Received	by 10.200.33.232 with SMTP id 37mr31115117qtz.189.1496217062566; Wed, 31 May 2017 00:51:02 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Content-Transfer-Encoding	8BIT
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	Al Viro <viro@zeniv.linux.org.uk>, Jeff Layton <jlayton@redhat.com>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, linux-nfs@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 31 May 2017 09:51:02 +0200
X-Original-Message-ID	<CAOssrKewzKn-5=b3n84mP=8EROCP22thcizggQfueh+CqDHKDg@mail.gmail.com>
X-Original-References	<149546825563.9289.9065118651584207610.stgit@warthog.procyon.org.uk> <20170530145043.GG6365@ZenIV.linux.org.uk> <15403.1496158574@warthog.procyon.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1653938

Show key headers only | View raw

On Tue, May 30, 2017 at 5:36 PM, David Howells <dhowells@redhat.com> wrote:
> Al Viro <viro@ZenIV.linux.org.uk> wrote:
>
>> Random notes:
>>       * "sb_config" looks rather odd in the current variant; mount_context,
>> perhaps?  Or fs_context, for that matter...  Anyway, that's trivial.
>
> You can argue that one with Miklós.  He argued against mount_context as I had
> it originally.  His point is that the same struct may be used when
> reconfiguring an sb - which isn't exactly a mount operation (even though we do
> it that day today with remount).

I'm fine with fs_context, just leave "mount" out of this.  Mounting is
the act of attaching the root dentry to the mountpoint. fs_context is
used for obtaining the root, but not for mounting itself, hence
mount_context is misleading IMO.

>>       * what the hell is ms_flags thing doing in __vfs_new_sb_config()?
>> It's a really vile mix of unrelated flags and operations we had in existing
>> mount(2) ABI.  With MS_KERNMOUNT thrown into that loo^Wmix.  Sure, we need
>> to parse the garbage fed to mount(2).  And we need to pass that garbage to
>> "legacy" types as well, but let's not inflict it upon the new mechanisms.
>
> I know, but we might get it from mount(2).  I can tamp down the flag mask and
> translate it from MS_*, but the MS_* flags are also stored in the superblock
> (->s_flags).

Good cleanup would be to just introduce a new set of flags for s_flags
and leave MS_* usage solely for the legacy mount(2) interface.

Thanks,
Miklos

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH 00/23] VFS: Introduce superblock configuration context [ver #4] David Howells <dhowells@redhat.com> - 2017-05-30 17:40 +0200
  Re: [RFC][PATCH 00/23] VFS: Introduce superblock configuration  context [ver #4] Miklos Szeredi <mszeredi@redhat.com> - 2017-05-31 10:00 +0200

csiph-web