Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1653901

Re: [PATCH] drm/pl111: select DRM_PANEL

From Daniel Vetter <daniel@ffwll.ch>
Newsgroups linux.kernel
Subject Re: [PATCH] drm/pl111: select DRM_PANEL
Date 2017-05-31 09:20 +0200
Message-ID <tN65b-1H4-11@gated-at.bofh.it> (permalink)
References <tMLDr-5ux-13@gated-at.bofh.it> <tMNFf-6JG-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, May 30, 2017 at 01:35:51PM +0200, Linus Walleij wrote:
> On Tue, May 30, 2017 at 11:22 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > When DRM_PANEL is disabled, we get a link error for pl111:
> >
> > drivers/gpu/built-in.o: In function `pl111_connector_destroy':
> > pl111_connector.c:(.text+0x3487e6): undefined reference to `drm_panel_detach'
> >
> > For some reason this only appears in the latest linux-next
> > although the driver appears to have used the symbol for a few
> > weeks already. The solution however is simple enough, we just
> > need to add a 'select' statement.
> >
> > Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Tested-by: Linus Walleij <linus.walleij@linaro.org>
> 
> I had the same patch in my tree, just haven't had time to send
> it out.

Eric seems out, so I picked this up for him. Thanks for the patch&testing.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] drm/pl111: select DRM_PANEL Arnd Bergmann <arnd@arndb.de> - 2017-05-30 11:30 +0200
  Re: [PATCH] drm/pl111: select DRM_PANEL Linus Walleij <linus.walleij@linaro.org> - 2017-05-30 13:40 +0200
    Re: [PATCH] drm/pl111: select DRM_PANEL Daniel Vetter <daniel@ffwll.ch> - 2017-05-31 09:20 +0200

csiph-web