Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support

From	Dong Aisheng <dongas86@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support
Date	2017-05-31 08:40 +0200
Message-ID	<tN5st-1db-9@gated-at.bofh.it> (permalink)
References	<tIETU-39a-15@gated-at.bofh.it> <tL81r-4EH-3@gated-at.bofh.it> <tL8b8-4Xy-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnd,

On Thu, May 25, 2017 at 11:02:22PM +0200, Arnd Bergmann wrote:
> On Sat, May 13, 2017 at 9:29 AM, Dong Aisheng <aisheng.dong@nxp.com> wrote:
> 
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index 3356ab8..03dfd6a 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -590,6 +590,11 @@ config CLKSRC_IMX_GPT
> >         depends on ARM && CLKDEV_LOOKUP
> >         select CLKSRC_MMIO
> >
> > +config CLKSRC_IMX_TPM
> > +       bool "Clocksource using i.MX TPM" if COMPILE_TEST
> > +       depends on ARM && CLKDEV_LOOKUP && GENERIC_CLOCKEVENTS
> > +       select CLKSRC_MMIO
> > +
> 
> This needs a help text
> 

Got it

> 
> > +static inline void tpm_timer_disable(void)
> > +{
> > +       unsigned int val;
> > +
> > +       /* channel disable */
> > +       val = __raw_readl(timer_base + TPM_C0SC);
> > +       val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
> > +       __raw_writel(val, timer_base + TPM_C0SC);
> > +}
> 
> __raw_readl/__raw_writel is broken on big-endian kernels, please
> use readl/writel instead.
> 

That's true.

Thanks for the kind reminder.

Regards
Dong Aisheng

>         Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support Arnd Bergmann <arnd@arndb.de> - 2017-05-25 23:10 +0200
  Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support Dong Aisheng <dongas86@gmail.com> - 2017-05-31 08:40 +0200

csiph-web