Re: [HMM 06/15] mm/memory_hotplug: introduce add_pages

From	Balbir Singh <bsingharora@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [HMM 06/15] mm/memory_hotplug: introduce add_pages
Date	2017-05-31 03:40 +0200
Message-ID	<tN0M9-6u9-5@gated-at.bofh.it> (permalink)
References	<tKIgF-5fw-3@gated-at.bofh.it> <tKIgG-5fw-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 24 May 2017 13:20:15 -0400
Jérôme Glisse <jglisse@redhat.com> wrote:

> From: Michal Hocko <mhocko@suse.com>
> 
> There are new users of memory hotplug emerging. Some of them require
> different subset of arch_add_memory. There are some which only require
> allocation of struct pages without mapping those pages to the kernel
> address space. We currently have __add_pages for that purpose. But this
> is rather lowlevel and not very suitable for the code outside of the
> memory hotplug. E.g. x86_64 wants to update max_pfn which should be
> done by the caller. Introduce add_pages() which should care about those
> details if they are needed. Each architecture should define its
> implementation and select CONFIG_ARCH_HAS_ADD_PAGES. All others use
> the currently existing __add_pages.
> 
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
> ---

Acked-by: Balbir Singh <bsingharora@gmail.com>

Looks good, from a CDM perspective, this means that HMM-CDM would continue
to use arch_add_memory()

Balbir Singh.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [HMM 06/15] mm/memory_hotplug: introduce add_pages Balbir Singh <bsingharora@gmail.com> - 2017-05-31 03:40 +0200

csiph-web