Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1652568

Re: [PATCH] mmc: mediatek: Fixed size in dma_free_coherent

Show all headers | View raw

On 24 May 2017 at 09:53, Neil Armstrong <narmstrong@baylibre.com> wrote:
> From: Phong LE <ple@baylibre.com>
>
> The dma gpd dma_free_coherent call size in invalid.
>
> Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
> Signed-off-by: Phong LE <ple@baylibre.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/mtk-sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 5c1e178..5a672a5 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1774,7 +1774,7 @@ static int msdc_drv_remove(struct platform_device *pdev)
>         pm_runtime_disable(host->dev);
>         pm_runtime_put_noidle(host->dev);
>         dma_free_coherent(&pdev->dev,
> -                       sizeof(struct mt_gpdma_desc),
> +                       2 * sizeof(struct mt_gpdma_desc),
>                         host->dma.gpd, host->dma.gpd_addr);
>         dma_free_coherent(&pdev->dev, MAX_BD_NUM * sizeof(struct mt_bdma_desc),
>                         host->dma.bd, host->dma.bd_addr);
> --
> 2.7.4
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: mediatek: Fixed size in dma_free_coherent Ulf Hansson <ulf.hansson@linaro.org> - 2017-05-29 16:50 +0200

csiph-web