Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to tb_ctl_free()

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to tb_ctl_free()
Date	2017-05-29 14:20 +0200
Message-ID	<tMrOp-8a6-5@gated-at.bofh.it> (permalink)
References	<tLq81-87A-5@gated-at.bofh.it> <tLq83-87A-69@gated-at.bofh.it> <tLM8x-5Sc-15@gated-at.bofh.it> <tM1AB-7P8-3@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Sun, 2017-05-28 at 11:13 +0300, Mika Westerberg wrote:
> On Sat, May 27, 2017 at 06:41:28PM +0300, Andy Shevchenko wrote:
> > On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg
> > <mika.westerberg@linux.intel.com> wrote:
> > > Following the usual pattern used in many places, we allow passing
> > > NULL
> > > pointer to tb_ctl_free(). Then the user can call the function
> > > regardless
> > > if it has allocated control channel or not making the code bit
> > > simpler.
> > > 
> > 
> > +Suggested-by as you mentioned in cover letter?
> 
> OK, I'll add it.
> 
> BTW, should I do it for the other patch that was suggested by Andreas
> as
> well?

Sure


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 07/27] thunderbolt: Allow passing NULL to tb_ctl_free() Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-26 18:20 +0200
  Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to tb_ctl_free() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-27 17:50 +0200
    Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to tb_ctl_free() Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-28 10:20 +0200
      Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to  tb_ctl_free() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-29 14:20 +0200

csiph-web