Re: [PATCH] mm: Define KB, MB, GB, TB in core VM

From	Michael Ellerman <michaele@au1.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: Define KB, MB, GB, TB in core VM
Date	2017-05-29 13:00 +0200
Message-ID	<tMqz0-77t-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <tK2Ua-2m2-17@gated-at.bofh.it> <tKc78-8iP-21@gated-at.bofh.it> <tKdwe-Fm-35@gated-at.bofh.it> <tKgaK-2wv-17@gated-at.bofh.it> <tKyhk-79n-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Anshuman Khandual <khandual@linux.vnet.ibm.com> writes:
>
> So the question is are we willing to do all these changes across
> the tree to achieve common definitions of KB, MB, GB, TB in the
> kernel ? Is it worth ?

No I don't think it's worth the churn.

But have you looked at using the "proper" names, ie. KiB, MiB, GiB?

AFAICS the only clash is:

drivers/mtd/ssfdc.c:#define KiB(x)	( (x) * 1024L )
drivers/mtd/ssfdc.c:#define MiB(x)	( KiB(x) * 1024L )

Which would be easy to convert.

cheers

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mm: Define KB, MB, GB, TB in core VM Michael Ellerman <michaele@au1.ibm.com> - 2017-05-29 13:00 +0200

csiph-web