Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1652378

Re: [PATCH] powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function
Date 2017-05-29 11:40 +0200
Message-ID <tMpjA-6jW-25@gated-at.bofh.it> (permalink)
References <tKzwJ-88W-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, May 24, 2017 at 10:01 AM, Christophe Leroy
<christophe.leroy@c-s.fr> wrote:

> of_mm_gpiochip_add_data() generates an Oops for NULL pointer dereference.
>
> of_mm_gpiochip_add_data() calls mm_gc->save_regs() before
> setting the data, therefore ->save_regs() cannot use gpiochip_get_data()
>
> Fixes: 937daafca774b ("powerpc: simple-gpio: use gpiochip data pointer")
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Sorry for any screwups I've caused...

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 11:40 +0200

csiph-web