Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1652303

Re: [PATCH] gpio: davinci: Handle return value of clk_prepare_enable

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] gpio: davinci: Handle return value of clk_prepare_enable
Date 2017-05-29 10:50 +0200
Message-ID <tMoxb-5JZ-1@gated-at.bofh.it> (permalink)
References <tKeiB-1cT-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, May 23, 2017 at 11:18 AM, Arvind Yadav
<arvind.yadav.cs@gmail.com> wrote:

> clk_prepare_enable() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Patch applied.

Normally we use goto's for the errorpath but in this case I see the
goto is used for positive exit in this driver so this solution is less
messy than adding another goto path.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] gpio: davinci: Handle return value of clk_prepare_enable Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 10:50 +0200

csiph-web