Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1652301

Re: [PATCH 0/3] ipc subsystem refcounter conversions

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 0/3] ipc subsystem refcounter conversions
Date 2017-05-29 10:40 +0200
Message-ID <tMonv-5Ga-11@gated-at.bofh.it> (permalink)
References <tcUtX-453-3@gated-at.bofh.it> <th5TP-zw-11@gated-at.bofh.it> <tLQ2u-8qB-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sat, May 27, 2017 at 12:58:14PM -0700, Kees Cook wrote:
> FAST_REFCOUNT=n: use function-based refcount_t with cmpxvhg and
> full-verification
> FAST_REFCOUNT=y without arch-specific implementation: use atomic_t
> with no verification (i.e. no functional change from now)
> FAST_REFCOUNT=y with arch-specific implementation: use atomic_t with
> overflow protection
> 
> which means FAST_REFCOUNT would need to be default-on so that mm,
> block, net users will remain happy.
> 
> Does that sound reasonable?

I'd rather turn the options around so that the atomic_t or fast
arch implementations are the defaul.  But either way it needs to
be configurable.  Once that is done we can spread refcount_t everywhere
and everyone will be better off, if only for the documentation value
of the type when they use the atomic_t based implementation.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0/3] ipc subsystem refcounter conversions Kees Cook <keescook@chromium.org> - 2017-05-27 22:00 +0200
  Re: [PATCH 0/3] ipc subsystem refcounter conversions Christoph Hellwig <hch@infradead.org> - 2017-05-29 10:40 +0200
    Re: [PATCH 0/3] ipc subsystem refcounter conversions ebiederm@xmission.com (Eric W. Biederman) - 2017-05-29 11:20 +0200
      Re: [PATCH 0/3] ipc subsystem refcounter conversions Peter Zijlstra <peterz@infradead.org> - 2017-05-29 12:30 +0200
        Re: [PATCH 0/3] ipc subsystem refcounter conversions ebiederm@xmission.com (Eric W. Biederman) - 2017-05-29 13:00 +0200
          Re: [PATCH 0/3] ipc subsystem refcounter conversions ebiederm@xmission.com (Eric W. Biederman) - 2017-05-29 13:40 +0200
            Re: [PATCH 0/3] ipc subsystem refcounter conversions ebiederm@xmission.com (Eric W. Biederman) - 2017-05-29 13:50 +0200
              Re: [PATCH 0/3] ipc subsystem refcounter conversions Peter Zijlstra <peterz@infradead.org> - 2017-05-29 14:30 +0200
                Re: [PATCH 0/3] ipc subsystem refcounter conversions Peter Zijlstra <peterz@infradead.org> - 2017-05-29 17:50 +0200
          Re: [PATCH 0/3] ipc subsystem refcounter conversions Peter Zijlstra <peterz@infradead.org> - 2017-05-29 14:20 +0200

csiph-web