Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions
Date	Mon, 29 May 2017 10:30:02 +0200
Message-ID	<tModQ-5Cf-19@gated-at.bofh.it> (permalink)
References	<tK2AN-1ZI-3@gated-at.bofh.it> <tK2AN-1ZI-1@gated-at.bofh.it>
X-Original-To	Paul Gortmaker <paul.gortmaker@windriver.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KiJue6MYpdikunLvz72239KIElE61+V1twG/aI0dhBI=; b=jiFR9uCZB55aLL/sOBwvCyeOrGMDeBzNOCT2uDsHYWi8fA7A4DIt6NQvwp8U5tn5M8 ZnFMPP/ZXC9C6OcDJ4nz4YgdsTEgsqdr422X72eynclDIbd4AiMiktniGMMwjZpme1FW NWIxe8s3TYJROaY/ENhmMxnkFuQBx1//yXbQI=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KiJue6MYpdikunLvz72239KIElE61+V1twG/aI0dhBI=; b=dgAF6c6GnFArizqG/U0WT/N1DPhqOcoZL4wmkNO9cOMVInT4kb+d70jLoBIbPA5fam icVeGc7HfsKK/WlGAYGFgbsMKDuSI9y8C2R/PYDuMKe8J2ui3RdTbpyD/G+M54hJ50Lb YUZcsyg6kbpPLP9mEyI35DXyqaO18yDxqk6VX1asCJ3kB+pFOigg1w0P2jlv8ZfQ/Lch hcGeEW3pl9MHPvyxdU/dS8/yRWaS+fksgW90iFt7tN+eHE/62CRxtGOUkukM+jXLXaVu vdKyLdVm2/sD2epUb3T9nZ8ZJRHqQinlA04mkyfn6O5oOvejxHQ8vXsq+3dCh/++wZcl UPMA==
X-Gm-Message-State	AODbwcAcDKGrhrK7jTZPdgkPkhYyP0BJqjk5l2DLgzUv82mQV+rs0Rp2 syhOQVN/7Ghy8k6aSybi2hwaBhimf9LB
X-Received	by 10.36.104.72 with SMTP id v69mr28599150itb.27.1496046248789; Mon, 29 May 2017 01:24:08 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Tomasz Figa <tomasz.figa@gmail.com>, Thomas Abraham <thomas.ab@samsung.com>, linux-samsung-soc <linux-samsung-soc@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
X-Original-Date	Mon, 29 May 2017 10:24:07 +0200
X-Original-Message-ID	<CACRpkdb_4_9884AWCxv6OYFPzcRdS9YHAe8YrJ7hPxHvzDuf=g@mail.gmail.com>
X-Original-References	<20170522205648.23545-1-paul.gortmaker@windriver.com> <20170522205648.23545-2-paul.gortmaker@windriver.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1652290

Show key headers only | View raw

On Mon, May 22, 2017 at 10:56 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> Fixups here tend to be more all over the map vs. some of the other
> repeated/systematic ones we've seen elsewhere.
>
> We remove module.h from code that isn't doing anything modular at
> all;  if they have __init sections, then replace it with init.h
>
> A couple drivers have module_exit() code that is essentially orphaned,
> and so we remove that.
>
> There are no module_init replacements, so we have no concerns wrt.
> initcall ordering changes as per some of the other cleanups.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Krzysztof is sub-submainter for the Samsung stuff in pinctrl so I
leave it to him to figure out how to bend, twist and merge this, then
I will get the result back from him with a pull request.

It looks good to me though.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 10:30 +0200

csiph-web