Re: [PATCH] spi: add null check before pointer dereference

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] spi: add null check before pointer dereference
Date	2017-05-29 06:00 +0200
Message-ID	<tMk0x-2Jc-1@gated-at.bofh.it> (permalink)
References	<tMk0x-2Jc-3@gated-at.bofh.it> <tK5S1-4cN-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Gustavo,

>  	desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents,
>  				       dma->direction, DMA_PREP_INTERRUPT);
>  
> +	if (!desc) {
> +		dev_err(&sdd->master->dev,
> +			"%s:dmaengine_prep_slave_sg Failed\n", __func__);
> +		return;
> +	}
> +

I'm sorry, I would nack this patch for now. There was a smilar I
sent before, but, as Krzysztof said, this needs more testing and
a proper solution.

That's anyway in my todo list.

Thanks,
Andi

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] spi: add null check before pointer dereference Andi Shyti <andi.shyti@samsung.com> - 2017-05-29 06:00 +0200
  Re: [PATCH] spi: add null check before pointer dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-30 04:40 +0200

csiph-web