Re: [PATCH] pinctrl: mcp23s08: improve I2C Kconfig dependency

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: mcp23s08: improve I2C Kconfig dependency
Date	2017-05-31 02:00 +0200
Message-ID	<tMZdn-5ry-11@gated-at.bofh.it> (permalink)
References	<tMLtO-5qE-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 30, 2017 at 11:11 AM, Arnd Bergmann <arnd@arndb.de> wrote:

> With "SPI_MASTER=y && I2C=m", we can build mcp23s08 as a built-in driver,
> which then results in a link failure:
>
> drivers/pinctrl/built-in.o: In function `mcp23s08_probe_one.isra.0':
> :(.text+0x7910): undefined reference to `__devm_regmap_init_i2c'
> drivers/pinctrl/built-in.o: In function `mcp23s08_init':
> :(.init.text+0x110): undefined reference to `i2c_register_driver'
> drivers/pinctrl/built-in.o: In function `mcp23s08_exit':
> :(.exit.text+0x3c): undefined reference to `i2c_del_driver'
>
> To avoid the problem, this adds another dependency on I2C that enforces
> mcp23s08 to be a loadable module whenever the I2C core is a module.
>
> Fixes: 64ac43e6fa28 ("gpio: mcp23s08: move to pinctrl")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied!

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: mcp23s08: improve I2C Kconfig dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-30 11:20 +0200
  Re: [PATCH] pinctrl: mcp23s08: improve I2C Kconfig dependency Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-30 12:30 +0200
  Re: [PATCH] pinctrl: mcp23s08: improve I2C Kconfig dependency Linus Walleij <linus.walleij@linaro.org> - 2017-05-31 02:00 +0200

csiph-web