Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1653720

Re: [PATCH] staging: android: uapi: drop definitions of removed ION_IOC_{FREE,SHARE} ioctls

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Laura Abbott <labbott@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: android: uapi: drop definitions of removed ION_IOC_{FREE,SHARE} ioctls
Date Wed, 31 May 2017 01:40:02 +0200
Message-ID <tMYU2-5kF-9@gated-at.bofh.it> (permalink)
References <tMQa5-8s0-13@gated-at.bofh.it>
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PqplPhjYKRx8qwhSB9jqVT3HLHst9HB//gIjxoouwW0=; b=ceK1tAap3Wfa2qcTfk7V9qxsr5+g0ItmtCBJQtu7Q1Kx5Fvh2Qu1a51eWB4702CuU5 TjglrBe77i2UfhsSVYknXZz/d2Ch0X4cXHe7in8bGRtDC4bsdYrqN5ivetty3WvwzHKH 35xo5/khkbkqtbCz8sT28/u1Bin/kRm4riBmFDBpljQFfrKe6V0gspa5pot85vqmIJS/ BRHvt1N7NO1yemKoN0tGPc8xWwQoCbhTcMjRrSw8tQCyAVkq16DSOAKlFXIpyX0j+1d/ Kp2q7aENLpYk00m0vvcrfUuBi51fvsz2ilv5Eg/fATCBwoThEKXfuphne4BwF1dgDWRU 57MA==
X-Gm-Message-State AODbwcA2datZIefKThfPACHobthNx2AF3X/fx12SdPNuevUdgGiwXAhf c41jnhh/qmAa+ypz
X-Received by 10.237.36.219 with SMTP id u27mr29975616qtc.197.1496187240598; Tue, 30 May 2017 16:34:00 -0700 (PDT)
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0
MIME-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Language en-US
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 41
Organization linux.* mail to news gateway
X-Original-Cc Sumit Semwal <sumit.semwal@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Arve Hjønnevåg <arve@android.com>, Riley Andrews <riandrews@android.com>, devel@driverdev.osuosl.org, "Dmitry V. Levin" <ldv@altlinux.org>
X-Original-Date Tue, 30 May 2017 16:33:57 -0700
X-Original-Message-ID <3725e052-5e57-3455-01e2-76ee33eeb15b@redhat.com>
X-Original-References <20170530141128.GA1469@glebfm.cloud.tilaa.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1653720

Show key headers only | View raw


On 05/30/2017 07:11 AM, Gleb Fotengauer-Malinovskiy wrote:
> This problem was found by strace ioctl list generator.
> 
> Fixes: 15c6098cfec5 ("staging: android: ion: Remove ion_handle and ion_client")
> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
> ---
>  drivers/staging/android/uapi/ion.h | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index b76db1b..a291b12 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -131,24 +131,6 @@ struct ion_heap_query {
>  				      struct ion_allocation_data)
>  
>  /**
> - * DOC: ION_IOC_FREE - free memory
> - *
> - * Takes an ion_handle_data struct and frees the handle.
> - */
> -#define ION_IOC_FREE		_IOWR(ION_IOC_MAGIC, 1, struct ion_handle_data)
> -
> -/**
> - * DOC: ION_IOC_SHARE - creates a file descriptor to use to share an allocation
> - *
> - * Takes an ion_fd_data struct with the handle field populated with a valid
> - * opaque handle.  Returns the struct with the fd field set to a file
> - * descriptor open in the current address space.  This file descriptor
> - * can then be passed to another process.  The corresponding opaque handle can
> - * be retrieved via ION_IOC_IMPORT.
> - */
> -#define ION_IOC_SHARE		_IOWR(ION_IOC_MAGIC, 4, struct ion_fd_data)
> -
> -/**
>   * DOC: ION_IOC_HEAP_QUERY - information about available heaps
>   *
>   * Takes an ion_heap_query structure and populates information about
> 

Acked-by: Laura Abbott <labbott@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] staging: android: uapi: drop definitions of removed  ION_IOC_{FREE,SHARE} ioctls Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> - 2017-05-30 16:20 +0200
  Re: [PATCH] staging: android: uapi: drop definitions of removed  ION_IOC_{FREE,SHARE} ioctls Laura Abbott <labbott@redhat.com> - 2017-05-31 01:40 +0200

csiph-web