Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653493

Re: [PATCH v2 6/7] gpio: mockup: improve the error message

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 6/7] gpio: mockup: improve the error message
Date 2017-05-30 21:00 +0200
Message-ID <tMUx3-2xi-5@gated-at.bofh.it> (permalink)
References <tMLaq-54b-5@gated-at.bofh.it> <tMLaq-54b-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, May 30, 2017 at 11:58 AM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> Indicate the error number and make the message a bit more elaborate.

> +                       dev_err(dev,
> +                               "adding gpiochip failed: %d (base: %d, ngpio: %d)\n",
> +                               ret, base, base < 0 ? ngpio : base + ngpio);

You may consider to use
'gpio_mockup_add' instead of 'adding gpiochip'. The latter points the
reader first to gpiochip_add family of functions while you run a
wrapper on top of it.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 6/7] gpio: mockup: improve the error message Bartosz Golaszewski <brgl@bgdev.pl> - 2017-05-30 11:00 +0200
  Re: [PATCH v2 6/7] gpio: mockup: improve the error message Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 21:00 +0200
    Re: [PATCH v2 6/7] gpio: mockup: improve the error message Bartosz Golaszewski <brgl@bgdev.pl> - 2017-05-31 13:00 +0200
      Re: [PATCH v2 6/7] gpio: mockup: improve the error message Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-31 17:10 +0200
        Re: [PATCH v2 6/7] gpio: mockup: improve the error message Bartosz Golaszewski <brgl@bgdev.pl> - 2017-05-31 17:30 +0200
          Re: [PATCH v2 6/7] gpio: mockup: improve the error message Bartosz Golaszewski <brgl@bgdev.pl> - 2017-06-01 09:20 +0200

csiph-web