Re: [PATCH net] net/mlx5: avoid build warning for uniprocessor

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] net/mlx5: avoid build warning for uniprocessor
Date	2017-05-30 20:10 +0200
Message-ID	<tMTKG-2ga-17@gated-at.bofh.it> (permalink)
References	<tMsAO-jT-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 29 May 2017 15:00:17 +0200

> Building the driver with CONFIG_SMP disabled results in a harmless
> warning:
> 
> ethernet/mellanox/mlx5/core/main.c: In function 'mlx5_irq_set_affinity_hint':
> ethernet/mellanox/mlx5/core/main.c:615:6: error: unused variable 'irq' [-Werror=unused-variable]
> 
> It's better to express the conditional compilation using IS_ENABLED()
> here, as that lets the compiler see what the intented use for the variable
> is, and that it can be silently discarded.
> 
> Fixes: b665d98edc9a ("net/mlx5: Tolerate irq_set_affinity_hint() failures")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] net/mlx5: avoid build warning for uniprocessor Arnd Bergmann <arnd@arndb.de> - 2017-05-29 15:10 +0200
  Re: [PATCH net] net/mlx5: avoid build warning for uniprocessor Saeed Mahameed <saeedm@dev.mellanox.co.il> - 2017-05-30 09:30 +0200
  Re: [PATCH net] net/mlx5: avoid build warning for uniprocessor David Miller <davem@davemloft.net> - 2017-05-30 20:10 +0200

csiph-web