Re: [PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated
Date	2017-05-30 18:30 +0200
Message-ID	<tMSbT-1dJ-7@gated-at.bofh.it> (permalink)
References	<tMQjL-8vK-3@gated-at.bofh.it> <tMQjM-8vK-9@gated-at.bofh.it> <tMRfQ-DG-13@gated-at.bofh.it> <tMRzb-KJ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 30, 2017 at 11:41:51AM -0400, Vivien Didelot wrote:
> Hi Andrew,
> 
> Andrew Lunn <andrew@lunn.ch> writes:
> 
> > On Tue, May 30, 2017 at 10:21:28AM -0400, Vivien Didelot wrote:
> >> If the receive function of a tagger reallocated the SKB, the original
> >> SKB is currently not freed. Fix this and free it on both copy or error.
> >
> > I don't see any of the receive functions reallocate the skb. It might
> > be better to just simplify the code to take away the option to return
> > a different skb.
> 
> I think it was written such way to be symmetrical with the xmit
> implementation, where the trailer tagger does reallocate the skb.

trailer_xmit() releases the original and so does the in-review KSZ
tagger.

So i think in general, Rx and Rx, the tagger should be responsible for
freeing the original, but on error the core should do the free.

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 16:30 +0200
  Re: [PATCH net-next 4/7] net: dsa: free orig skb on rcv if  reallocated Andrew Lunn <andrew@lunn.ch> - 2017-05-30 17:30 +0200
    Re: [PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-30 17:50 +0200
      Re: [PATCH net-next 4/7] net: dsa: free orig skb on rcv if  reallocated Andrew Lunn <andrew@lunn.ch> - 2017-05-30 18:30 +0200

csiph-web