Re: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU

From	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU
Date	2017-05-30 13:50 +0200
Message-ID	<tMNOW-6P4-27@gated-at.bofh.it> (permalink)
References	<tMLtL-5qE-3@gated-at.bofh.it> <tMLtM-5qE-35@gated-at.bofh.it> <tMMJc-6ag-11@gated-at.bofh.it>
Organization	Free Electrons

Show all headers | View raw

Hello,

Thanks for the quick review!

On Tue, 30 May 2017 11:37:10 +0100, Marc Zyngier wrote:

> > +  The 1st cell is the group type of the ICU interrupt (SPI_NSR,
> > +  SPI_SR, SEI, and REI).  
> 
> Is it worth documenting what these are?

Sure, will do.

> > +icu: interrupt-controller@1e0000 {
> > +	compatible = "marvell,icu";
> > +	reg = <0x1e0000 0x10>;
> > +	#interrupt-cells = <2>;  
> 
> Oh wait...

Gaah, I did spot this mistake, but then forgot to fix it. Will do.

> > +	interrupt-controller;
> > +	interrupt-parent = <&gic>;
> > +	gicp = <&gicp>;  
> 
> Should this be prefixed with a vendor specific identifier, just in case?

Would marvell,gicp be preferable?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-30 11:20 +0200
  Re: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for  the Marvell ICU Marc Zyngier <marc.zyngier@arm.com> - 2017-05-30 12:40 +0200
    Re: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding  for the Marvell ICU Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-30 13:50 +0200

csiph-web