Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback

From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback
Date	2017-05-30 12:30 +0200
Message-ID	<tMMzv-677-7@gated-at.bofh.it> (permalink)
References	<tL1W1-TD-3@gated-at.bofh.it> <tL1W3-TD-55@gated-at.bofh.it> <tMMzv-677-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Archit,

On Tue, 2017-05-30 at 15:54 +0530, Archit Taneja wrote:
> Hi,
> 
> On 05/25/2017 07:49 PM, Jose Abreu wrote:
> > Now that we have a callback to check if bridge supports a given mode
> > we can use it in Synopsys Designware HDMI bridge so that we restrict
> > the number of probbed modes to the ones we can actually display.
> >
> > Also, there is no need to use mode_fixup() callback as mode_valid()
> > will handle the mode validation.
> >
> > NOTE: Only compile tested
> > NOTE 2: I also had to change the pdata declaration of mode_valid
> > custom callback so that the passed modes are const. I also changed
> > in the platforms I found. Not even compiled it though.
> 
> This compiles fine and has been tested on Meson by Neil.
> 
> Since this also touches rockchip/imx drm driver files, can I get an
> OK from the maintainers to pull the changes via drm-misc?

Of course,
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

Thread

[PATCH v5 00/10] Introduce new mode validation callbacks Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-25 16:30 +0200
  [PATCH v5 03/10] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-25 16:30 +0200
    Re: [PATCH v5 03/10] drm: Use new mode_valid() helpers in connector  probe helper Neil Armstrong <narmstrong@baylibre.com> - 2017-05-30 09:30 +0200
  [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-25 16:30 +0200
    Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use  bridge->mode_valid() callback Neil Armstrong <narmstrong@baylibre.com> - 2017-05-29 11:50 +0200
    Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use  bridge->mode_valid() callback Philipp Zabel <p.zabel@pengutronix.de> - 2017-05-30 12:30 +0200
      Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use  bridge->mode_valid() callback Archit Taneja <architt@codeaurora.org> - 2017-06-05 10:00 +0200
    Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use  bridge->mode_valid() callback Archit Taneja <architt@codeaurora.org> - 2017-05-30 12:30 +0200

csiph-web