Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653108

Re: [PATCH v2] powerpc/fadump: return error when fadump registration fails

Show all headers | View raw

Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com> writes:

> On 05/27/2017 09:16 PM, Michal Suchanek wrote:
>>  - log an error message when registration fails and no error code listed
>>  in the switch is returned
>>  - translate the hv error code to posix error code and return it from
>>  fw_register
>>  - return the posix error code from fw_register to the process writing
>>  to sysfs
>>  - return EEXIST on re-registration
>>  - return success on deregistration when fadump is not registered
>>  - return ENODEV when no memory is reserved for fadump
>
> Why do we need this ?

Because that's how we do error handling.

> Userspace can always read back the fadump registration status from
> /sys/kernel/fadump_registered (after echo 1 to it) to find out
> whether fadump registration succeeded or not.

That's a terrible API.

If we followed that example, open() wouldn't return a value, you'd have
to do another syscall to check if it worked.

I'd appreciate if someone could test this and give me a Tested-by.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] powerpc/fadump: return error when fadump registration fails Michal Suchanek <msuchanek@suse.de> - 2017-05-27 17:50 +0200
  Re: [PATCH v2] powerpc/fadump: return error when fadump registration  fails Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com> - 2017-05-30 06:50 +0200
    Re: [PATCH v2] powerpc/fadump: return error when fadump registration fails Michael Ellerman <mpe@ellerman.id.au> - 2017-05-30 12:50 +0200
  Re: [PATCH v2] powerpc/fadump: return error when fadump registration  fails Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-06-01 12:10 +0200
  Re: [v2] powerpc/fadump: return error when fadump registration fails Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-06-05 12:30 +0200

csiph-web