Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1652967

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

Show all headers | View raw

On Sat, 27 May 2017 16:46:15 +0200,
Bhumika Goyal wrote:
> 
> Declare snd_kcontrol_new structures as const as they are only passed an
> argument to the function snd_ctl_new1. This argument is of type const,
> so snd_kcontrol_new structures having this property can be made const.
> Done using Coccinelle:
> 
> @r disable optional_qualifier@
> identifier x;
> position p;
> @@
> static struct snd_kcontrol_new x@p={...};
> 
> @ok@
> identifier r.x;
> position p;
> @@
> snd_ctl_new1(&x@p,...)
> 
> @bad@
> position p != {r.p,ok.p};
> identifier r.x;
> @@
> x@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r.x;
> @@
> +const
> struct snd_kcontrol_new x;
> 
> Cross compiled these files:
> sound/aoa/codecs/tas.c - powerpc
> sound/mips/{hal2.c/sgio2audio.c} - mips
> sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc
> sound/soc/sh/siu_dai.c - sh
> Could not find an architecture to compile sound/sh/aica.c.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied now, as it looks safe enough.  But I prefer splitting to
individual patches, so please try to do that at the next time.


thanks,

Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: declare snd_kcontrol_new structures as const Bhumika Goyal <bhumirks@gmail.com> - 2017-05-27 17:00 +0200
  Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const Mark Brown <broonie@kernel.org> - 2017-05-29 15:20 +0200
  Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const Takashi Iwai <tiwai@suse.de> - 2017-05-30 11:00 +0200
    Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const Bhumika Goyal <bhumirks@gmail.com> - 2017-05-30 11:00 +0200
    Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const Julia Lawall <julia.lawall@lip6.fr> - 2017-05-30 11:00 +0200
      Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const Bhumika Goyal <bhumirks@gmail.com> - 2017-05-30 11:10 +0200
      Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const Takashi Iwai <tiwai@suse.de> - 2017-05-30 11:10 +0200

csiph-web