[PATCH v2 5/7] gpio: mockup: don't return magic numbers from probe()

From	Bartosz Golaszewski <brgl@bgdev.pl>
Newsgroups	linux.kernel
Subject	[PATCH v2 5/7] gpio: mockup: don't return magic numbers from probe()
Date	2017-05-30 11:00 +0200
Message-ID	<tMLaq-54b-21@gated-at.bofh.it> (permalink)
References	<tMLaq-54b-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

When the requested number of GPIO lines is 0, return -EINVAL, not
-1 which is -EPERM.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 drivers/gpio/gpio-mockup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 0cb6cba..ab2d38e 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -369,7 +369,7 @@ static int gpio_mockup_probe(struct platform_device *pdev)
 			ret = gpio_mockup_add(dev, &chips[i],
 					      chip_name, base, ngpio);
 		} else {
-			ret = -1;
+			ret = -EINVAL;
 		}
 
 		if (ret) {
-- 
2.9.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 5/7] gpio: mockup: don't return magic numbers from probe() Bartosz Golaszewski <brgl@bgdev.pl> - 2017-05-30 11:00 +0200

csiph-web