Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653042

Re: [PATCH 7/7] nvme: provide UUID value to userspace

Show all headers | View raw

On Tue, May 30, 2017 at 10:08:22AM +0200, Johannes Thumshirn wrote:
> Now that we have a way for getting the UUID from a target, provide it
> to userspace as well.
> 
> Unfortunately there is already a sysfs attribute called UUID which is
> a misnomer as it holds the NGUID value. So instead of creating yet
> another wrong name, create a new 'nguid' sysfs attribute for the
> NGUID. For the UUID attribute add a check wheter the namespace has a
> UUID assigned to it and return this or return the NGUID to maintain
> backwards compatibility. This should give userspace a chance to catch
> up.

Eww.  This looks pretty sketchy and at least needs a good comment in
the source.  Maybe even a printk_ratelimited warning.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn <jthumshirn@suse.de> - 2017-05-30 10:10 +0200
  [PATCH 4/7] nvme: also report include the EUI-64 in identify NS report Johannes Thumshirn <jthumshirn@suse.de> - 2017-05-30 10:10 +0200
    Re: [PATCH 4/7] nvme: also report include the EUI-64 in identify NS  report Hannes Reinecke <hare@suse.de> - 2017-05-30 10:30 +0200
    Re: [PATCH 4/7] nvme: also report include the EUI-64 in identify         NS report Christoph Hellwig <hch@lst.de> - 2017-05-30 11:30 +0200
  [PATCH 7/7] nvme: provide UUID value to userspace Johannes Thumshirn <jthumshirn@suse.de> - 2017-05-30 10:20 +0200
    Re: [PATCH 7/7] nvme: provide UUID value to userspace Christoph Hellwig <hch@lst.de> - 2017-05-30 11:40 +0200
      Re: [PATCH 7/7] nvme: provide UUID value to userspace Johannes Thumshirn <jthumshirn@suse.de> - 2017-05-30 12:30 +0200
  [PATCH 6/7] nvme: get list of namespace descriptors Johannes Thumshirn <jthumshirn@suse.de> - 2017-05-30 10:20 +0200
    Re: [PATCH 6/7] nvme: get list of namespace descriptors Hannes Reinecke <hare@suse.de> - 2017-05-30 10:40 +0200
  [PATCH 5/7] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-05-30 10:20 +0200
    Re: [PATCH 5/7] nvmet: implement namespace identify descriptor list Hannes Reinecke <hare@suse.de> - 2017-05-30 10:30 +0200
  Re: [PATCH 0/7] Implement NVMe Namespace Descriptor Identification Christoph Hellwig <hch@lst.de> - 2017-05-31 11:50 +0200
    Re: [PATCH 0/7] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn <jthumshirn@suse.de> - 2017-05-31 13:30 +0200

csiph-web