Re: [PATCH 1/1] nvme: fix nvme_remove going to uninterruptible sleep for ever

From	Rakesh Pandit <rakesh@tuxera.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] nvme: fix nvme_remove going to uninterruptible sleep for ever
Date	2017-05-30 09:20 +0200
Message-ID	<tMJBD-49a-13@gated-at.bofh.it> (permalink)
References	<tMmvn-4sB-1@gated-at.bofh.it> <tMx7r-3jN-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 29, 2017 at 07:58:39PM +0200, Christoph Hellwig wrote:
> On Mon, May 29, 2017 at 09:29:54AM +0300, Rakesh Pandit wrote:
> > Once controller is in DEAD or DELETING state a call to delete_destroy
> > from nvme_uninit_ctrl results in setting the latency tolerance via
> > nvme_set_latency_tolerance callback even though queues have already
> > been killed.  This in turn leads the PID to go into uninterruptible
> > sleep and prevents removal of nvme controller from completion.  The
> > stack trace is:
...
> 
> What do you think about moving this into the beginning of
> nvme_configure_apst instead?  And please add a comment while you're
> at it.

Thanks, makes sense.  I have posted V2.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] nvme: fix nvme_remove going to uninterruptible sleep for  ever Rakesh Pandit <rakesh@tuxera.com> - 2017-05-29 08:40 +0200
  Re: [PATCH 1/1] nvme: fix nvme_remove going to uninterruptible         sleep for ever Christoph Hellwig <hch@lst.de> - 2017-05-29 20:00 +0200
    Re: [PATCH 1/1] nvme: fix nvme_remove going to uninterruptible sleep  for ever Rakesh Pandit <rakesh@tuxera.com> - 2017-05-30 09:20 +0200

csiph-web