Re: [PATCH 2/2] Input: pm8941-pwrkey: Introduce reboot mode support

From	Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] Input: pm8941-pwrkey: Introduce reboot mode support
Date	2017-05-30 06:50 +0200
Message-ID	<tMHgt-2mn-7@gated-at.bofh.it> (permalink)
References	<tLDRD-8cl-1@gated-at.bofh.it> <tLDRD-8cl-3@gated-at.bofh.it> <tMFy2-12b-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon 29 May 19:53 PDT 2017, Dmitry Torokhov wrote:

> On Fri, May 26, 2017 at 11:51:30PM -0700, Bjorn Andersson wrote:
> > In some Qualcomm platforms the magic for informing LK which mode to
> > reboot into is stored in the PON_SOFT_RB_SPARE register. Register with
> > the reboot mode helpers to expose this to the user.
> 
> Hmm, is the power key driver the best place to have this? WHy isn't this
> a driver in its own right?
> 

The functionality is part of the "PON" block in the Qualcomm PMICs,
other functionality from this block relates to configuration and
handling related to power-key and reset-key.

Several of these properties are intermingled, so I do believe it's best
to handle them in a single driver; that said, it might no longer be
correct to name the driver "pwrkey" or that it is a "misc input" driver.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] power: reset: reboot-mode: Make include file global Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-27 09:00 +0200
  [PATCH 2/2] Input: pm8941-pwrkey: Introduce reboot mode support Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-27 09:00 +0200
    Re: [PATCH 2/2] Input: pm8941-pwrkey: Introduce reboot mode support Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-30 05:00 +0200
      Re: [PATCH 2/2] Input: pm8941-pwrkey: Introduce reboot mode support Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-30 06:50 +0200

csiph-web