Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference

From	James Smart <james.smart@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference
Date	2017-05-30 01:10 +0200
Message-ID	<tMBXr-72G-3@gated-at.bofh.it> (permalink)
References	<tKjBE-4S4-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Looks good

Signed-off-by: James Smart <james.smart@broadcom.com>

-- james


On 5/23/2017 8:09 AM, Gustavo A. R. Silva wrote:
> Null check at line 966: if (ndlp) {,  implies that ndlp might be NULL.
> Functions lpfc_nlp_set_state() and lpfc_issue_els_prli() dereference
> pointer ndlp. Include these function calls inside the IF block that
> tests pointer ndlp.
>
> Addresses-Coverity-ID: 1401856
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference James Smart <james.smart@broadcom.com> - 2017-05-30 01:10 +0200

csiph-web