Re: [PATCH v3 09/10] gpio-exar/8250-exar: Make set of exported GPIOs configurable

From	Jan Kiszka <jan.kiszka@siemens.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 09/10] gpio-exar/8250-exar: Make set of exported GPIOs configurable
Date	2017-05-28 18:40 +0200
Message-ID	<tM9ot-4pq-3@gated-at.bofh.it> (permalink)
References	<tLpYm-83M-3@gated-at.bofh.it> <tLpYm-83M-23@gated-at.bofh.it> <tLKq5-4JN-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-05-27 15:48, Andy Shevchenko wrote:
> On Fri, May 26, 2017 at 7:02 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On the SIMATIC, IOT2040 only a single pin is exportable as GPIO, the
>> rest is required to operate the UART. To allow modeling this case,
>> expand the platform device data structure to specify a (consecutive) pin
>> subset for exporting by the gpio-exar driver.
> 
>> +       unsigned int first_pin;
> 
>> +       if (device_property_read_u32(&pdev->dev, "first_pin", &first_pin) < 0 ||
> 
> And again, we need to follow the rules of the device property
> bindings. (No underscores - use dashes; name should be registered).
> 
> Without Rafael's / Mika's and Rob's opinions I would not go with a
> such name even for internal property.
> 
> DWC3 (USB) for example is still using "linux," prefix. I dunno if it's
> the case here, I mean can or can't we use similar approach.
> 
>> +           device_property_read_u32(&pdev->dev, "npins", &npins) < 0)
> 
> "ngpios"
> 

Yeah, forgot to change all this before reposting. Will make the names
DT-alike.

But there is nothing to register: DT shall stay away from this device.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 09/10] gpio-exar/8250-exar: Make set of exported GPIOs configurable Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-26 18:10 +0200
  Re: [PATCH v3 09/10] gpio-exar/8250-exar: Make set of exported GPIOs configurable Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-27 16:00 +0200
    Re: [PATCH v3 09/10] gpio-exar/8250-exar: Make set of exported GPIOs  configurable Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-28 18:40 +0200

csiph-web