Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1651706
| Path | csiph.com!goblin3!goblin1!goblin.stu.neva.ru!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/5] HID: intel_ish-hid: fix format string for size_t |
| Date | Sat, 27 May 2017 03:40:02 +0200 |
| Message-ID | <tLyRY-4YN-27@gated-at.bofh.it> (permalink) |
| References | <tIAdz-8oW-3@gated-at.bofh.it> <tIAdA-8oW-23@gated-at.bofh.it> |
| X-Original-To | Arnd Bergmann <arnd@arndb.de>, Jiri Kosina <jikos@kernel.org> |
| X-Extloop1 | 1 |
| X-Ironport-Av | E=Sophos;i="5.38,399,1491289200"; d="scan'208";a="1174851888" |
| Content-Type | text/plain; charset="UTF-8" |
| X-Mailer | Evolution 3.20.5 (3.20.5-1.fc24) |
| MIME-Version | 1.0 |
| Content-Transfer-Encoding | 8bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 44 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-input@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Fri, 26 May 2017 13:58:47 -0700 |
| X-Original-Message-ID | <1495832327.79527.5.camel@linux.intel.com> |
| X-Original-References | <20170518202144.3482304-1-arnd@arndb.de> <20170518202144.3482304-5-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1651706 |
Show key headers only | View raw
On Thu, 2017-05-18 at 22:21 +0200, Arnd Bergmann wrote:
> When building for 32-bit architectures, we get a harmless warning:
>
> intel-ish-hid/ishtp-hid-client.c: In function 'process_recv':
> intel-ish-hid/ishtp-hid-client.c:139:7: error: format '%lu' expects
> argument of type 'long unsigned int', but argument 3 has type
> 'unsigned int' [-Werror=format=]
>
> This changes the format string to print size_t variables using %zu
> instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c
> b/drivers/hid/intel-ish-hid/ishtp-hid-client.c
> index 5c643d7a07b2..157b44aacdff 100644
> --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c
> +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c
> @@ -136,10 +136,9 @@ static void process_recv(struct ishtp_cl
> *hid_ishtp_cl, void *recv_buf,
> if (1 + sizeof(struct device_info) *
> i >=
> payload_len) {
> dev_err(&client_data-
> >cl_device->dev,
> - "[hid-ish]:
> [ENUM_DEVICES]: content size %lu is bigger than payload_len %u\n",
> + "[hid-ish]:
> [ENUM_DEVICES]: content size %zu is bigger than payload_len %zu\n",
> 1 + sizeof(struct
> device_info)
> - * i,
> - (unsigned
> int)payload_len);
> + * i, payload_len);
> }
>
> if (1 + sizeof(struct device_info) *
> i >=
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v2 4/5] HID: intel_ish-hid: fix format string for size_t Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2017-05-27 03:40 +0200
csiph-web