[PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Murilo Opsfelder Araujo <mopsfelder@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
Date	Sat, 27 May 2017 03:40:01 +0200
Message-ID	<tLyRX-4YN-5@gated-at.bofh.it> (permalink)
X-Original-To	linux-kernel@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ynqJtbYKx+rovFEBtiaCgLah9S20mxJmfBAhhmvtumk=; b=gJT2LCs6h7+QE7es+/LSJmiRP36fZJobOlWFxJuW8XSvoSQ363iiwQyrq7PPCp5VJq bS04GTUQDnkQQzXH7BV5v4DioifVoxyeeDep1sJ94uf9Tl4lcF2MjvRz66s+Y4CcbBmx Z1EJKxlLlBMbEsAy4PNoNAN5VZ0GFoq/VUYtHgoM8ZtMcC53p1roIW8QK3od5tqSzGPx 0H901+xrjdguXEUyBjiDt3pRv5peO8c7/aKcKOfyYghX6pKuMgaBinULLXO7q8YUCI7B BkEQ+T8imgHxJRV5GbP8/oA1/HrQ8QXtRhgrnrO9yo7WMBtYglU5AhxQIxMX7xiITqbW aK9g==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ynqJtbYKx+rovFEBtiaCgLah9S20mxJmfBAhhmvtumk=; b=GvW2NRs1oMvoB3Gx6gIP3l4aboqvU8cNUbSTcAcG4cFCQTCLWhHajzjo/LACZ61iEc aidLCQ7KoXUZ8eW54xNsYi8RJQ4ewjHFSYOuGphA0MRwcQBeHf1JpEFsGV/CyfETwroO snObJYyUp/phj5mJfBHXdhyCqg5r/0vFcWm5fynsZE3hycBzq0FUqK7Ch+VBkkAj8wd8 wzHSUJe/8BUVsnQ9hK1/9h9htgkXeOLm04skbJVP464Ry6aEjHJS4j1IcHkjb5JIGdzg NBDH2nC7wkYGo5v+cjHA40Vh0ZjM3kA4ggAmtbVNGV58aKJbYTTFIjIyAVmbMiRse+bw IGFQ==
X-Gm-Message-State	AODbwcAcB8RFnbN3O+HBifab7IJ7yLcyg89aw9WqJrggyZm+Xsy8H3yz ga6kN7aaGrD5ffhwSMI=
X-Received	by 10.200.49.1 with SMTP id g1mr6297372qtb.118.1495848194903; Fri, 26 May 2017 18:23:14 -0700 (PDT)
X-Mailer	git-send-email 2.9.4
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	linux-watchdog@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>, Wim Van Sebroeck <wim@iguana.be>, Michael Ellerman <mpe@ellerman.id.au>, Murilo Opsfelder Araujo <mopsfelder@gmail.com>
X-Original-Date	Fri, 26 May 2017 22:22:56 -0300
X-Original-Message-ID	<20170527012256.6005-1-mopsfelder@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1651689

Show key headers only | View raw

drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
setting CONFIG_PPC_RTAS throws the following errors:

    ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
    ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
    ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
    ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
    ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!

This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
CONFIG_PPC_RTAS was not set. Logs are here:

    http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/

This patch fixes the issue by selecting CONFIG_PPC_RTAS when
CONFIG_WATCHDOG_RTAS is set.

Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 8b9049d..5d872145 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1689,6 +1689,7 @@ config MEN_A21_WDT
 config WATCHDOG_RTAS
 	tristate "RTAS watchdog"
 	depends on PPC_RTAS || (PPC64 && COMPILE_TEST)
+	select PPC_RTAS
 	help
 	  This driver adds watchdog support for the RTAS watchdog.
 
-- 
2.9.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Murilo Opsfelder Araujo <mopsfelder@gmail.com> - 2017-05-27 03:40 +0200
  Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS  dependencies Guenter Roeck <linux@roeck-us.net> - 2017-05-27 04:00 +0200
    Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Michael Ellerman <mpe@ellerman.id.au> - 2017-05-29 04:10 +0200
      Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS  dependencies Murilo Opsfelder Araújo <mopsfelder@gmail.com> - 2017-05-29 15:40 +0200

csiph-web