Re: [PATCH v2 1/3] EDAC: mv64x60: remove unused variable

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] EDAC: mv64x60: remove unused variable
Date	Sat, 27 May 2017 03:40:01 +0200
Message-ID	<tLyRX-4YN-1@gated-at.bofh.it> (permalink)
References	<tIp8t-7LV-11@gated-at.bofh.it> <tIp8u-7LV-31@gated-at.bofh.it>
X-Original-To	Chris Packham <chris.packham@alliedtelesis.co.nz>
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au
X-Original-Date	Fri, 26 May 2017 22:51:38 +0200
X-Original-Message-ID	<20170526205137.ktm53pf3lcn6oarm@pd.tnic>
X-Original-References	<20170518083135.28048-1-chris.packham@alliedtelesis.co.nz> <20170518083135.28048-2-chris.packham@alliedtelesis.co.nz>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1651688

Show key headers only | View raw

On Thu, May 18, 2017 at 08:31:33PM +1200, Chris Packham wrote:
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>  drivers/edac/mv64x60_edac.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c
> index 14b7e7b71eaa..454e1e26ee7c 100644
> --- a/drivers/edac/mv64x60_edac.c
> +++ b/drivers/edac/mv64x60_edac.c
> @@ -853,8 +853,6 @@ static struct platform_driver * const drivers[] = {
>  
>  static int __init mv64x60_edac_init(void)
>  {
> -	int ret = 0;
> -
>  	printk(KERN_INFO "Marvell MV64x60 EDAC driver " MV64x60_REVISION "\n");
>  	printk(KERN_INFO "\t(C) 2006-2007 MontaVista Software\n");
>  	/* make sure error reporting method is sane */
> -- 

Looks like the logic behind that ret variable is to catch the retval of
platform_register_drivers() and test it to return early. And then issue
the printks and assign edac_op_state only in the success case.

Please do that instead.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/3] EDAC: mv64x60: remove unused variable Borislav Petkov <bp@alien8.de> - 2017-05-27 03:40 +0200

csiph-web