Re: arm64 test_user_copy crash on copy_from_user(uptr, kptr, size)

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: arm64 test_user_copy crash on copy_from_user(uptr, kptr, size)
Date	2017-05-27 03:30 +0200
Message-ID	<tLyIi-4Vw-29@gated-at.bofh.it> (permalink)
References	<tLplE-7AP-9@gated-at.bofh.it> <tLpF0-7Hk-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 26, 2017 at 5:41 PM, Kees Cook <keescook@chromium.org> wrote:
> On Fri, May 26, 2017 at 8:24 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> A kselftest run on arm64 on an older 4.4.y stable kernel ran into an
>> unexpectedly trapping user space access:
>>
>> [ 1277.857738] Internal error: Accessing user space memory outside
>> uaccess.h routines: 96000045 [#1] PREEMPT SMP
>>
>> Apparently the same thing happens on x86 as well, and it still happens on
>> the latest kernels, see https://bugs.linaro.org/show_bug.cgi?id=3011
>>
>> The problem here is this test
>>
>>        ret |= test(!copy_from_user(bad_usermem, (char __user *)kmem,
>>                                    PAGE_SIZE),
>>                    "illegal reversed copy_from_user passed");
>
> Hi! Yes, I removed that test from the current code:
>
> #if 0
>         /*
>          * When running with SMAP/PAN/etc, this will Oops the kernel
>          * due to the zeroing of userspace memory on failure. This needs
>          * to be tested in LKDTM instead, since this test module does not
>          * expect to explode.
>          */
>         ret |= test(!copy_from_user(bad_usermem, (char __user *)kmem,
>                                     PAGE_SIZE),
>                     "illegal reversed copy_from_user passed");
> #endif
>
> We can send a patch to -stable?

Ok, good. I've prepared a backport since it doesn't apply cleanly otherwise.

        Arnd

Thread

arm64 test_user_copy crash on copy_from_user(uptr, kptr, size) Arnd Bergmann <arnd@arndb.de> - 2017-05-26 17:30 +0200
  Re: arm64 test_user_copy crash on copy_from_user(uptr, kptr, size) Kees Cook <keescook@chromium.org> - 2017-05-26 17:50 +0200
    Re: arm64 test_user_copy crash on copy_from_user(uptr, kptr, size) Arnd Bergmann <arnd@arndb.de> - 2017-05-27 03:30 +0200
  Re: arm64 test_user_copy crash on copy_from_user(uptr, kptr, size) Arnd Bergmann <arnd@arndb.de> - 2017-05-27 03:30 +0200

csiph-web