Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block()

From	Luis Henriques <lhenriques@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block()
Date	2017-05-26 19:20 +0200
Message-ID	<tLr45-hm-11@gated-at.bofh.it> (permalink)
References	<tL3br-1AL-3@gated-at.bofh.it> <tL3bs-1AL-29@gated-at.bofh.it> <tLpYm-83M-13@gated-at.bofh.it> <tLqhI-8aW-19@gated-at.bofh.it> <tLqhI-8aW-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 26, 2017 at 05:23:30PM +0100, Catalin Marinas wrote:
> On Fri, May 26, 2017 at 05:21:08PM +0100, Catalin Marinas wrote:
> > On Fri, May 26, 2017 at 05:09:17PM +0100, Luis Henriques wrote:
> > > On Thu, May 25, 2017 at 04:42:16PM +0100, Catalin Marinas wrote:
> > > > The scan_block() function updates the number of references (pointers) to
> > > > objects, adding them to the gray_list when object->min_count is reached.
> > > > The patch factors out this functionality into a separate update_refs()
> > > > function.
> > > > 
> > > > Cc: Michal Hocko <mhocko@kernel.org>
> > > > Cc: Andy Lutomirski <luto@amacapital.net>
> > > > Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>
> > > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> [...]
> > > FWIW, I've tested this patchset and I don't see kmemleak triggering the
> > > false positives anymore.
> > 
> > Thanks for re-testing (I dropped your tested-by from the initial patch
> > since I made a small modification).
> 
> Sorry, the "re-testing" comment was meant at the other Luis on cc ;)
> (Luis R. Rodriguez). It's been a long day...

Heh, no worries!  What are the odds of having 2 different guys named Luis
testing the same patch? :-)

Cheers,
--
Luís

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] mm: kmemleak: Improve vmalloc() false positives for thread stack allocation Catalin Marinas <catalin.marinas@arm.com> - 2017-05-25 17:50 +0200
  [PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block() Catalin Marinas <catalin.marinas@arm.com> - 2017-05-25 17:50 +0200
    Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating  out of scan_block() Luis Henriques <lhenriques@suse.com> - 2017-05-26 18:10 +0200
      Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating  out of scan_block() Catalin Marinas <catalin.marinas@arm.com> - 2017-05-26 18:30 +0200
        Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating  out of scan_block() Catalin Marinas <catalin.marinas@arm.com> - 2017-05-26 18:30 +0200
          Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating  out of scan_block() Luis Henriques <lhenriques@suse.com> - 2017-05-26 19:20 +0200

csiph-web