Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1651414

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized
Date 2017-05-26 16:40 +0200
Message-ID <tLozf-73D-11@gated-at.bofh.it> (permalink)
References <tLkYF-4LU-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 2017-05-26 at 03:48 -0700, Richard Narron wrote:
> The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD
> and NetBSD partitions and does a reasonable job picking out OpenBSD
> and NetBSD UFS subpartitions.
> 
> But for FreeBSD the subpartitions are always "bad".
> 
>      Kernel: <bsd:bad subpartition - ignored
[]
>   block/partitions/msdos.c | 2 ++
[]
> @@ -300,6 +300,8 @@ static void parse_bsd(struct parsed_part
>   			continue;
>   		bsd_start = le32_to_cpu(p->p_offset);
>   		bsd_size = le32_to_cpu(p->p_size);
> +		if (memcmp(flavour, "bsd\0", 4) == 0)

Weird code.  Why not:

		if (strcmp(flavor, "bsd") == 0)

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not  recognized Richard Narron <comet.berkeley@gmail.com> - 2017-05-26 12:50 +0200
  Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are  not recognized Jens Axboe <axboe@kernel.dk> - 2017-05-26 15:30 +0200
  Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are  not recognized Joe Perches <joe@perches.com> - 2017-05-26 16:40 +0200
    Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are  not recognized Joe Perches <joe@perches.com> - 2017-05-27 03:30 +0200
      Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are  not recognized Joe Perches <joe@perches.com> - 2017-05-27 04:00 +0200
        Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are  not recognized Richard Narron <comet.berkeley@gmail.com> - 2017-05-27 05:30 +0200
          Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are  not recognized Joe Perches <joe@perches.com> - 2017-05-27 06:30 +0200
    Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are  not recognized Richard Narron <comet.berkeley@gmail.com> - 2017-05-27 03:40 +0200

csiph-web