Re: [tip:timers/core] mmtimer: Remove the SGI SN2 mmtimer driver

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [tip:timers/core] mmtimer: Remove the SGI SN2 mmtimer driver
Date	2017-05-26 16:50 +0200
Message-ID	<tLoIV-77d-7@gated-at.bofh.it> (permalink)
References	<tLjJg-44G-23@gated-at.bofh.it> <tLli1-57l-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2017-05-26 at 03:58 -0700, tip-bot for Christoph Hellwig wrote:
> Commit-ID:  07903ada96139ced48f2f893fe57a26a8fbc6043

Couple trivial comments:

> mmtimer: Remove the SGI SN2 mmtimer driver
[]
>  drivers/char/mmtimer.c    | 858 ----------------------------------------------
>  include/uapi/linux/time.h |   6 +-
[]
> diff --git a/drivers/char/mmtimer.c b/drivers/char/mmtimer.c
> deleted file mode 100644
> index 0e7fcb0..0000000
> --- a/drivers/char/mmtimer.c
> +++ /dev/null
> @@ -1,858 +0,0 @@
> -/*

[ etc...]

In the future, please use git format-patch -M to avoid
listing the
contents of the file deletion.

> diff --git a/include/uapi/linux/time.h b/include/uapi/linux/time.h
[]
> @@ -54,7 +54,11 @@ struct itimerval {
>  #define CLOCK_BOOTTIME			7
>  #define CLOCK_REALTIME_ALARM		8
>  #define CLOCK_BOOTTIME_ALARM		9
> -#define CLOCK_SGI_CYCLE			10	/* Hardware specific */
> +/*
> + * The driver implementing this got removed. The clock ID is kept as a
> + * place holder. Do not reuse!
> + */
> +#define CLOCK_SGI_CYCLE			10
>  #define CLOCK_TAI			11
>  
>  #define MAX_CLOCKS			16

Here the "this" comment is a bit ambiguous.

It might be better to rename CLOCK_SGI_CYCLE as well.
Maybe something like CLOCK_SGI_CYCLE_DELETED_DRIVER_DONT_REUSE.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

constify struct k_clock Christoph Hellwig <hch@lst.de> - 2017-05-26 11:30 +0200
  [PATCH 2/2] kernel: mark all struct k_clock instances const Christoph Hellwig <hch@lst.de> - 2017-05-26 11:30 +0200
    Re: [PATCH 2/2] kernel: mark all struct k_clock instances const Joe Perches <joe@perches.com> - 2017-05-26 11:40 +0200
      Re: [PATCH 2/2] kernel: mark all struct k_clock instances const Thomas Gleixner <tglx@linutronix.de> - 2017-05-26 12:40 +0200
        Re: [PATCH 2/2] kernel: mark all struct k_clock instances const Joe Perches <joe@perches.com> - 2017-05-26 18:20 +0200
    [tip:timers/core] posix-timers: Make posix_clocks immutable tip-bot for Christoph Hellwig <tipbot@zytor.com> - 2017-05-26 13:10 +0200
    [tip:timers/core] posix-timers: Make posix_clocks immutable tip-bot for Christoph Hellwig <tipbot@zytor.com> - 2017-05-26 14:50 +0200
    [tip:timers/core] posix-timers: Make posix_clocks immutable tip-bot for Christoph Hellwig <tipbot@zytor.com> - 2017-05-26 14:50 +0200
    [tip:timers/core] posix-timers: Make posix_clocks immutable tip-bot for Christoph Hellwig <tipbot@zytor.com> - 2017-05-27 10:00 +0200
  [PATCH 1/2] remove the SGI SN2 mmtimer driver Christoph Hellwig <hch@lst.de> - 2017-05-26 11:30 +0200
    [tip:timers/core] mmtimer: Remove the SGI SN2 mmtimer driver tip-bot for Christoph Hellwig <tipbot@zytor.com> - 2017-05-26 13:10 +0200
      Re: [tip:timers/core] mmtimer: Remove the SGI SN2 mmtimer driver Joe Perches <joe@perches.com> - 2017-05-26 16:50 +0200

csiph-web