Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1651357
| From | Michael Bringmann <mwb@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc |
| Date | 2017-05-26 14:30 +0200 |
| Message-ID | <tLmxr-5Rf-7@gated-at.bofh.it> (permalink) |
| References | <tL4TU-2Ht-25@gated-at.bofh.it> <tL4TU-2Ht-27@gated-at.bofh.it> <tLe6S-xj-5@gated-at.bofh.it> |
| Organization | IBM Linux Technology Center |
>> arch/powerpc/mm/numa.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c >> index 15c2dd5..18f3038 100644 >> --- a/arch/powerpc/mm/numa.c >> +++ b/arch/powerpc/mm/numa.c >> @@ -907,13 +907,6 @@ void __init initmem_init(void) >> >> memblock_dump_all(); >> >> - /* >> - * Reduce the possible NUMA nodes to the online NUMA nodes, >> - * since we do not support node hotplug. This ensures that we >> - * lower the maximum NUMA node ID to what is actually present. >> - */ >> - nodes_and(node_possible_map, node_possible_map, node_online_map); >> - > > There is an overhead with turning this off if you have too many cgroups > with the memory controller. I think this fix was added for a pathological > test case. On my system I see 84 cgroups with 1 node, so the probable > overhead is 84*255*sizeof(struct mem_cgroup_tree_per_node). > > I tried some patches to reduce the overhead, but those need more overhauling > and rework. Is there some other way to add a node to a dynamic, running system without crashing? I have not encountered one as yet. > Balbir Singh. -- Michael W. Bringmann Linux Technology Center IBM Corporation Tie-Line 363-5196 External: (512) 286-5196 Cell: (512) 466-0650 mwb@linux.vnet.ibm.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc Michael Bringmann <mwb@linux.vnet.ibm.com> - 2017-05-25 19:40 +0200
Re: [PATCH V2 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc Balbir Singh <bsingharora@gmail.com> - 2017-05-26 05:30 +0200
Re: [PATCH V2 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc Michael Bringmann <mwb@linux.vnet.ibm.com> - 2017-05-26 14:30 +0200
Re: [PATCH V2 2/2]: powerpc/hotplug/mm: Fix hot-add memory node assoc Michael Ellerman <mpe@ellerman.id.au> - 2017-05-26 07:40 +0200
csiph-web