Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1651350

Re: [PATCH 4/6] regulator: hi6421v530: add driver for hi6421v530 voltage regulator

From Javier Martinez Canillas <javier@dowhile0.org>
Newsgroups linux.kernel
Subject Re: [PATCH 4/6] regulator: hi6421v530: add driver for hi6421v530 voltage regulator
Date 2017-05-26 14:20 +0200
Message-ID <tLmnM-5Oa-7@gated-at.bofh.it> (permalink)
References <tLh4J-2oP-3@gated-at.bofh.it> <tLh4J-2oP-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello Guodong,

On Fri, May 26, 2017 at 8:35 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
> From: Wang Xiaoyin <hw.wangxiaoyin@hisilicon.com>
>

[snip]

>
> +config REGULATOR_HI6421V530
> +       tristate "HiSilicon Hi6421v530 PMIC voltage regulator support"

The Kconfig symbol is tristate so the driver can be built as a module...

> +
> +static struct platform_driver hi6421v530_regulator_driver = {
> +       .driver = {
> +               .name   = "hi6421v530-regulator",
> +       },
> +       .probe  = hi6421v530_regulator_probe,
> +};
> +module_platform_driver(hi6421v530_regulator_driver);

... but the driver doesn't have a platform device ID table nor export
it as a module alias using MODULE_DEVICE_TABLE().

That means that if built as a module, it won't be autoloaded when the
"hi6421v530-regulator" device is registered by the MFD driver.

> +
> +MODULE_AUTHOR("Wang Xiaoyin <hw.wangxiaoyin@hisilicon.com>");
> +MODULE_DESCRIPTION("Hi6421v530 regulator driver");
> +MODULE_LICENSE("GPL v2");

Alternative you can add a MODULE_ALIAS().

Best regards,
Javier

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] MFD: add driver for HiSilicon Hi6421v530 PMIC Guodong Xu <guodong.xu@linaro.org> - 2017-05-26 08:40 +0200
  [PATCH 2/6] mfd: hi6421-pmic: move hi6421_regmap_config definition to header file Guodong Xu <guodong.xu@linaro.org> - 2017-05-26 08:40 +0200
    Re: [PATCH 2/6] mfd: hi6421-pmic: move hi6421_regmap_config  definition to header file Arnd Bergmann <arnd@arndb.de> - 2017-05-26 10:40 +0200
      Re: [PATCH 2/6] mfd: hi6421-pmic: move hi6421_regmap_config  definition to header file Guodong Xu <guodong.xu@linaro.org> - 2017-05-27 05:10 +0200
  [PATCH 4/6] regulator: hi6421v530: add driver for hi6421v530 voltage regulator Guodong Xu <guodong.xu@linaro.org> - 2017-05-26 08:40 +0200
    Re: [PATCH 4/6] regulator: hi6421v530: add driver for hi6421v530  voltage regulator Mark Brown <broonie@kernel.org> - 2017-05-26 13:40 +0200
      Re: [PATCH 4/6] regulator: hi6421v530: add driver for hi6421v530  voltage regulator Guodong Xu <guodong.xu@linaro.org> - 2017-05-27 11:50 +0200
    Re: [PATCH 4/6] regulator: hi6421v530: add driver for hi6421v530  voltage regulator Javier Martinez Canillas <javier@dowhile0.org> - 2017-05-26 14:20 +0200
      Re: [PATCH 4/6] regulator: hi6421v530: add driver for hi6421v530  voltage regulator Guodong Xu <guodong.xu@linaro.org> - 2017-05-27 11:50 +0200
  [PATCH 6/6] arm64: defconfig: enable hi6421v530 MFD and regulator Guodong Xu <guodong.xu@linaro.org> - 2017-05-26 08:40 +0200
  [PATCH 5/6] arm64: dts: hikey960: add device node for pmic and regulators Guodong Xu <guodong.xu@linaro.org> - 2017-05-26 08:40 +0200
  [PATCH 1/6] dt-bindings: mfd: Add hi6421v530 bindings Guodong Xu <guodong.xu@linaro.org> - 2017-05-26 08:40 +0200
    Re: [PATCH 1/6] dt-bindings: mfd: Add hi6421v530 bindings Rob Herring <robh@kernel.org> - 2017-05-31 20:10 +0200
      Re: [PATCH 1/6] dt-bindings: mfd: Add hi6421v530 bindings Guodong Xu <guodong.xu@linaro.org> - 2017-06-02 11:10 +0200

csiph-web