Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1651303

Re: [PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas OneWire (W1) bus

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, May 25, 2017 at 11:14:39PM +0300, Evgeniy Polyakov wrote:

> Frankly saying, your non-regmap version was so much simpler, smaller and cleaner.
> I wonder why did people force you to use regmap.

> Guys, please speak up, if you want driver authors to use THIS, it is really flawed.

> Sebastien, iirc it was your idea to use regmaps, what was the reason for this?

So, this is the first I've seen of this series but in general the main
reason for using regmap is that it allows best practice to be factored
out into common code both in terms of the I/O itself and also in terms
of framework code being able to provide regmap based helpers for common
operations so drivers need less code.  The cache code is also really
useful for a lot of devices, it's a performance boost for reads and is
well optimized for restoring device state if you don't care about
sequencing (this is where some of the MMIO users come from).  You also
get a bunch of debug support for free, things like the tracepoints and
debugfs files (those do work better if you describe the register map).

Looking at the code in the regmap patch I have to say I'm very surprised
if this is adding much complexity, usually moving to regmap is basically
a sed.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas OneWire (W1) bus "Alex A. Mihaylov" <minimumlaw@rambler.ru> - 2017-05-25 19:50 +0200
  Re: [PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas  OneWire (W1) bus Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-25 21:00 +0200
    Re: [PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas  OneWire (W1) bus Mark Brown <broonie@kernel.org> - 2017-05-26 12:00 +0200
  Re: [PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas  OneWire (W1) bus Mark Brown <broonie@kernel.org> - 2017-05-26 12:30 +0200
    Re: [PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas  OneWire (W1) bus "Alex A. Mihaylov" <minimumlaw@rambler.ru> - 2017-05-26 18:00 +0200
  Re: [PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas  OneWire (W1) bus Mark Brown <broonie@kernel.org> - 2017-05-26 13:10 +0200
    Re: [PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas  OneWire (W1) bus "Alex A. Mihaylov" <minimumlaw@rambler.ru> - 2017-05-26 18:20 +0200
    Re: [PATCH 1/4] Introduce regmap infrastructure over Maxim/Dalas  OneWire (W1) bus Mark Brown <broonie@kernel.org> - 2017-05-26 19:20 +0200

csiph-web