Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1651319

Re: linux-next: build warning after merge of the akpm-current tree

Show all headers | View raw

On 05/26/2017 05:16 AM, Jeff Layton wrote:
> On Fri, 2017-05-26 at 12:43 +1000, Stephen Rothwell wrote:
>> Hi Andrew,
>>
>> After merging the akpm-current tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> fs/jfs/jfs_metapage.c: In function 'force_metapage':
>> fs/jfs/jfs_metapage.c:714:2: warning: ignoring return value of 'write_one_page', declared with attribute warn_unused_result [-Wunused-result]
>>   write_one_page(page);
>>   ^
>> fs/jfs/jfs_metapage.c: In function 'release_metapage':
>> fs/jfs/jfs_metapage.c:759:4: warning: ignoring return value of 'write_one_page', declared with attribute warn_unused_result [-Wunused-result]
>>     write_one_page(page);
>>     ^
>>
>> Introduced by commit
>>
>>   f8652aebee02 ("mm: drop "wait" parameter from write_one_page()")
>>
>> These call sites were updated for the droppping of the argument, but
>> not for the addition of __must_check :-(
>>
> 
> (cc'ing Dave...)
> 
> Yeah, that's a known issue. When Willy reviewed the patch originally he
> asked me to add a __must_check there so that JFS would pick up some
> warnings for this.
> 
> JFS really ought to check the return code there and do something sane
> with it. Dave?

This is true. I promised to do something about it. I'll try to get a
patch out later today.

Dave

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: build warning after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-26 04:50 +0200
  Re: linux-next: build warning after merge of the akpm-current tree Jeff Layton <jlayton@redhat.com> - 2017-05-26 12:20 +0200
    Re: linux-next: build warning after merge of the akpm-current tree Dave Kleikamp <dave.kleikamp@oracle.com> - 2017-05-26 13:30 +0200
    Re: [PATCH] JFS: do not ignore return code from write_one_page() Dave Kleikamp <dave.kleikamp@oracle.com> - 2017-05-27 03:30 +0200
      Re: [PATCH] JFS: do not ignore return code from write_one_page() Andrew Morton <akpm@linux-foundation.org> - 2017-05-27 08:40 +0200
        Re: [PATCH] JFS: do not ignore return code from write_one_page() Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-29 01:30 +0200
    [PATCH] JFS: do not ignore return code from write_one_page() Dave Kleikamp <dave.kleikamp@oracle.com> - 2017-05-27 03:40 +0200

csiph-web