Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1651093
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer |
| Date | 2017-05-26 08:00 +0200 |
| Message-ID | <tLgs2-1UV-13@gated-at.bofh.it> (permalink) |
| References | <tKbNM-7U4-17@gated-at.bofh.it> <tL31M-1xu-15@gated-at.bofh.it> <tLdku-8nJ-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, May 26, 2017 at 10:30:09AM +0800, jeffy wrote: > Hi sean, > > On 05/25/2017 11:30 PM, Sean Paul wrote: > > On Tue, May 23, 2017 at 02:39:43PM +0800, Jeffy Chen wrote: > > > The system would crash when trying to alloc zero sized gem buffer: > > > [ 6.712435] Unable to handle kernel NULL pointer dereference at virtual address 00000010 <--ZERO_SIZE_PTR > > > ... > > > [ 6.757502] PC is at sg_alloc_table_from_pages+0x170/0x1ec > > > > It's unfortunate that you didn't include the entire stack trace. From code > > inspection, it seems like the 0 size comes from the fb_probe path? Is there > > somewhere in the helpers that you could check the mode is sane so all drivers > > can benefit? > > hmm, sorry, i was testing it on chromeos 4.4 kernel, it turns out that we > have a custom ioctl for userspace to create gem buffer(the same as exynos > drm), which might get the the 0 size. > > but on upstream kernel, it could only be called by dump_create, and the > drm_mode_create_dumb_ioctl already did the size check. > > will resent this patch, and rewrite the commit message, thanx. That suggests that this patch isn't needed at all.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer Sean Paul <seanpaul@chromium.org> - 2017-05-25 17:40 +0200
Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer jeffy <jeffy.chen@rock-chips.com> - 2017-05-26 04:40 +0200
Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer Christoph Hellwig <hch@infradead.org> - 2017-05-26 08:00 +0200
Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer Daniel Vetter <daniel@ffwll.ch> - 2017-05-26 09:00 +0200
Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer Sean Paul <seanpaul@chromium.org> - 2017-05-26 16:00 +0200
csiph-web