Groups > linux.kernel > #1651987

Re: [PATCH v2 24/27] thunderbolt: Add support for Internal Connection Manager (ICM)

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 24/27] thunderbolt: Add support for Internal Connection Manager (ICM)
Date	Sat, 27 May 2017 22:50:02 +0200
Message-ID	<tLQOS-xo-29@gated-at.bofh.it> (permalink)
References	<tLq81-87A-5@gated-at.bofh.it> <tLq83-87A-65@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Jgtxd241Jea+maZGA7EDLXPROv6s/Jhth33sQ1lvsag=; b=KoFjHSPNH176wcvLsnkPM26/B47bCt7BRbvhm4KxrafAkrTrTks9XX50/0xbCSVRiF caB53eImSVzJZxON4s1Kg/KwBfNjDelbhbnYM/qnfAG/oSsPZnEhRZhgdaVk76ewGzu9 5vDF2EDP7obegGBk0vswMOpRQMLYK7vKEx09MKwJUcyDdVIDPHZSfrYBQmKed7MxiCy5 OsXuLyQSqJRSwegtQfdPsPA7sZzPE10DpB41DP0aukGqftldHPXiaIpl61QL0iEOl3St d81MsRT21HSPR1k9/OdCd0Tt6wlLMGHnEl1UgGN11+ctlb+34ZbikpNwOCHp2JBSLn9a WQ0g==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Jgtxd241Jea+maZGA7EDLXPROv6s/Jhth33sQ1lvsag=; b=ivIKySfxoTlzYqyrFIoS6dE+XkZxBU7WOHUHgtkglPFTpVgPM9OH9VRhpk8O7BTDdV 1bKru4zOwl+ccg2GZdgpmYwU0/9SeFnmyhNEkcXff76T1oLNIpNFpAyBR486NHHWEpGs I1Uh1nxfxImMkK7rn01eVfTX7/QFUAQvnVx2wBAnuTWsYZXFt6tnGWBuN+sTWH+tOKSm Q+q/niEewJwJ84esZVHdpaVu5xM73YJmewx0Vo71/lnwhhO5HOJpyjqe8rh7V+DfjZcE 8U6JPwFNGvV2miVlIZ5h7i2A7f3xOAeq8ZSmppAEAYjzOX3c5v1XVLlscf2a0+fi2oVi 4tiQ==
X-Gm-Message-State	AODbwcBicpjDZVpga19M7HyezY8KXp8xZA9XQjTPiYta54RQD+je0JAj mMBUYZH0leH10bnbBJzQeIRSLHDMww==
X-Received	by 10.55.1.79 with SMTP id 76mr9285560qkb.69.1495917922284; Sat, 27 May 2017 13:45:22 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	15
Organization	linux.* mail to news gateway
X-Original-Cc	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andreas Noever <andreas.noever@gmail.com>, Michael Jamet <michael.jamet@intel.com>, Yehezkel Bernat <yehezkel.bernat@intel.com>, Lukas Wunner <lukas@wunner.de>, Amir Levy <amir.jer.levy@intel.com>, Andy Lutomirski <luto@kernel.org>, Mario Limonciello <Mario.Limonciello@dell.com>, Jared.Dominguez@dell.com, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Sat, 27 May 2017 23:45:21 +0300
X-Original-Message-ID	<CAHp75Vc8pDPGrJH=UixW-r+kyT5K7wQXs8aN=SzooZpH9qnUcA@mail.gmail.com>
X-Original-References	<20170526160936.54265-1-mika.westerberg@linux.intel.com> <20170526160936.54265-25-mika.westerberg@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1651987

Show key headers only | View raw

On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:

> +static inline u8 dual_link_from_link(u8 link)
> +{
> +       return link ? ((link - 1) ^ 0x01) + 1 : 0;
> +}

I have got better one (IIUC):

      return (link + 1) ^ 0x01) - 1;

-- 
With Best Regards,
Andy Shevchenko

Thread

[PATCH v2 00/27] Thunderbolt security levels and NVM firmware upgrade Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-26 18:20 +0200
  Re: [PATCH v2 24/27] thunderbolt: Add support for Internal Connection  Manager (ICM) Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-27 22:50 +0200
    Re: [PATCH v2 24/27] thunderbolt: Add support for Internal  Connection Manager (ICM) Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-28 11:20 +0200
      Re: [PATCH v2 24/27] thunderbolt: Add support for Internal Connection  Manager (ICM) Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-28 12:20 +0200

csiph-web