Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1651950

Re: [PATCH v4 05/10] hyper-v: use fast hypercall for HVCALL_SIGNAL_EVENT

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 05/10] hyper-v: use fast hypercall for HVCALL_SIGNAL_EVENT
Date 2017-05-27 20:00 +0200
Message-ID <tLOam-7br-7@gated-at.bofh.it> (permalink)
References <tKDh0-2cD-7@gated-at.bofh.it> <tKDh1-2cD-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, May 24, 2017 at 3:04 PM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> We need to pass only 8 bytes of input for HvSignalEvent which makes it a
> perfect fit for fast hypercall. hv_input_signal_event_buffer is not needed
> any more and hv_input_signal_event is converted to union for convenience.

> +union hv_input_signal_event {

Union aliasing is UB. Avoid it for good.

> +       u64 as_uint64;
> +       struct {
> +               union hv_connection_id connectionid;
> +               u16 flag_number;
> +               u16 rsvdz;
> +       };
>  };

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v4 05/10] hyper-v: use fast hypercall for HVCALL_SIGNAL_EVENT Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-27 20:00 +0200

csiph-web