Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1651933

Re: [RFC PATCH] ASoC: Intel: sst: Delete sst_save_shim64(); saved regs are never used

Show all headers | View raw

On Fri, May 26, 2017 at 7:34 PM, Douglas Anderson <dianders@chromium.org> wrote:
> In commit 9a075265c6dc ("ASoC: Intel: sst: Remove unused function
> sst_restore_shim64()"), we deleted the sst_restore_shim64() since it
> was never used.  ...but a quick look at the code shows that we should
> also be able to remove the sst_save_shim64() function and the
> structure members we were storing data in.
>
> Note that the saving code (and the comments talking about how
> important it is to do the save) has been around since
> commit 336cfbb05edf ("ASoC: Intel: mrfld- add ACPI module").

While I like "-" statistics, the below I think should be preserved if
it's repeating real registers layout.

>  struct sst_shim_regs64 {
> -       u64 csr;
>         u64 pisr;
>         u64 pimr;
>         u64 isrx;
>         u64 isrd;
> -       u64 imrx;
>         u64 imrd;
>         u64 ipcx;
>         u64 ipcd;

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] ASoC: Intel: sst: Delete sst_save_shim64(); saved regs are never used Douglas Anderson <dianders@chromium.org> - 2017-05-26 18:40 +0200
  Re: [RFC PATCH] ASoC: Intel: sst: Delete sst_save_shim64(); saved  regs are never used Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-27 18:40 +0200
    Re: [RFC PATCH] ASoC: Intel: sst: Delete sst_save_shim64(); saved  regs are never used Doug Anderson <dianders@chromium.org> - 2017-05-30 19:00 +0200

csiph-web