Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1651847

Re: [PATCH] platform/x86: dell-wmi: Add a comment explaining the 0xb2 magic number

Show all headers | View raw

On Sat, May 27, 2017 at 8:15 AM, Darren Hart <dvhart@infradead.org> wrote:
> From: Andy Lutomirski <luto@kernel.org>
>
> The hotkey table is 0xb2, add a comment for clarity.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Suggested-by: Darren Hart <dvhart@infradead.org>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: "Pali Rohár" <pali.rohar@gmail.com>
> Cc: Andy Shevchenko <andy@infradead.org>
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> ---
>  drivers/platform/x86/dell-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 8a64c79..24467b1 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -449,6 +449,7 @@ static void __init handle_dmi_entry(const struct dmi_header *dm,
>         if (results->err || results->keymap)
>                 return;         /* We already found the hotkey table. */
>
> +       /* The Dell hotkey table is type 0xB2.  Scan until we find it. */
>         if (dm->type != 0xb2)
>                 return;
>
> --
> 2.9.4
>



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: dell-wmi: Add a comment explaining the 0xb2 magic number Darren Hart <dvhart@infradead.org> - 2017-05-27 07:20 +0200
  Re: [PATCH] platform/x86: dell-wmi: Add a comment explaining the 0xb2  magic number Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-27 12:40 +0200
  Re: [PATCH] platform/x86: dell-wmi: Add a comment explaining the 0xb2 magic number Pali Rohár <pali.rohar@gmail.com> - 2017-05-27 13:00 +0200
    Re: [PATCH] platform/x86: dell-wmi: Add a comment explaining the  0xb2 magic number Darren Hart <dvhart@infradead.org> - 2017-06-03 21:20 +0200

csiph-web